Page MenuHomePhabricator
Create Task
Maniphest T338085

Special:Impact fails to load
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The page hangs in a "loading" state. There's an error message in browser console:

Cannot read properties of null (reading 'impact')
   at initializeModule (load.php?lang=pl&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Cmoment%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.NewImpact%7Cext.wikimediaEvents.specialPages%7Cjquery.ui&skin=vector-2022&version=15uii:658:629)
   at load.php?lang=pl&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Cmoment%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.NewImpact%7Cext.wikimediaEvents.specialPages%7Cjquery.ui&skin=vector-2022&version=15uii:659:192

(the same happens with ?debug=2 flag in the URL)

What should have happened instead?:
The page should render properly, like it does on Special:Homepage

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
NewImpact: Fix renderMode parsing for Special:Impactmediawiki/extensions/GrowthExperimentswmf/1.41.0-wmf.11+9 -1
NewImpact: Fix renderMode parsing for Special:Impactmediawiki/extensions/GrowthExperimentsmaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Msz2001 created this task.Jun 3 2023, 5:39 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 3 2023, 5:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jun 5 2023, 9:06 AM
kostajh subscribed.

It looks like the patch rEGRE6e32d3fc49b0: New impact: show call to action in mobile-details mode (T337314) caused this.

kostajh claimed this task.Jun 5 2023, 9:06 AM
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jun 5 2023, 9:13 AM

Change 927121 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Fix renderMode parsing for Special:Impact

https://gerrit.wikimedia.org/r/927121

gerritbot added a project: Patch-For-Review.Jun 5 2023, 9:13 AM
kostajh triaged this task as High priority.Jun 5 2023, 9:13 AM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jun 5 2023, 10:55 AM

Change 927121 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Fix renderMode parsing for Special:Impact

https://gerrit.wikimedia.org/r/927121

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 5 2023, 10:58 AM

We will backport this to wmf.11 at some point today.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 5 2023, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 5 2023, 11:10 AM
gerritbot added a comment.Jun 5 2023, 8:37 PM

Change 926865 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.11] NewImpact: Fix renderMode parsing for Special:Impact

https://gerrit.wikimedia.org/r/926865

gerritbot added a project: Patch-For-Review.Jun 5 2023, 8:37 PM
gerritbot added a comment.Jun 5 2023, 9:01 PM

Change 926865 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.11] NewImpact: Fix renderMode parsing for Special:Impact

https://gerrit.wikimedia.org/r/926865

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2023, 9:10 PM
Stashbot added a comment.Jun 5 2023, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-05T21:17:08Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:926865|NewImpact: Fix renderMode parsing for Special:Impact (T338085)]]

Stashbot added a comment.Jun 5 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-05T21:30:41Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:926865|NewImpact: Fix renderMode parsing for Special:Impact (T338085)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jun 5 2023, 9:42 PM

Mentioned in SAL (#wikimedia-operations) [2023-06-05T21:42:47Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:926865|NewImpact: Fix renderMode parsing for Special:Impact (T338085)]] (duration: 25m 38s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.11; 2023-05-30); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 5 2023, 10:00 PM
Etonkovidova closed this task as Resolved.Jun 8 2023, 12:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL