Page MenuHomePhabricator
Create Task
Maniphest T338187

Change img_upright configuration in MessagesHu.php
Open, Needs TriagePublic
Actions

Description

The "upright" value of img_upright in languages/messages/MessagesHu.php is mistranslated to fennjobbra. Correct translation would be álló.
Please replace fennjobbra in the value of img_upright with álló
Configuration file: /source/mediawiki/browse/master/languages/messages/MessagesHu.php$207, line 207
New value would look like:

	'img_upright'               => [ '1', 'álló', 'álló=$1', 'álló $1', 'upright', 'upright=$1', 'upright $1' ],

Discussion to change this setting: https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Kocsmafal_(k%C3%A9pek)&oldid=26177366#K%C3%A9p_upright_param%C3%A9ter

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hungarian: Fix img_upright translation while maintaining backward compatibilitymediawiki/coremaster+1 -1
Hungarian: Fix img_upright translation while maintaining backward compatibilitymediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Bean49 created this task.Jun 5 2023, 9:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2023, 9:58 PM
Zabe edited projects, added MediaWiki-Internationalization; removed Wikimedia-Site-requests.Jun 6 2023, 3:00 PM
Tgr added a project: good first task.Jun 7 2023, 6:16 PM
Tgr subscribed.

Do you want to submit a patch?

We should probably keep fennjobbra for backwards compatibility.

Tacsipacsi subscribed.Jun 7 2023, 8:35 PM
In T338187#8910907, @Tgr wrote:

We should probably keep fennjobbra for backwards compatibility.

Most definitely. It’s been around for more than fifteen years (8b8fd9cbca03), it may be in use in many Hungarian-language projects.

Frostly claimed this task.Sep 30 2023, 9:01 PM
Frostly added a project: User-Frostly.
Frostly subscribed.
srishakatux mentioned this in T399682: Quarterly newcomer tasks on language technical projects (July–September 2025).Jul 16 2025, 6:17 AM
Aklapper removed Frostly as the assignee of this task.Fri, Feb 6, 1:43 PM

@Frostly Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on 2025-11-25.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Complicatedintegral claimed this task.Fri, Feb 6, 3:53 PM
Complicatedintegral subscribed.

I can take this task up. The proposed change looks clear and is supposed by the discussion linked in the description as well. I will prepare a patch in a while and update here.

gerritbot added a comment.Fri, Feb 6, 4:15 PM

Change #1237530 had a related patch set uploaded (by Complicatedintegral; author: Complicatedintegral):

[mediawiki/core@master] Hungarian: Fix translation of img_upright

https://gerrit.wikimedia.org/r/1237530

gerritbot added a project: Patch-For-Review.Fri, Feb 6, 4:15 PM
Complicatedintegral added a comment.Fri, Feb 6, 4:27 PM

Sorry I was not sure whether I was supposed to work on this task, but I have uploaded a patch according to the request in the description incase it will be helpful.

Aklapper added a comment.Fri, Feb 6, 6:22 PM
In T338187#11592024, @Complicatedintegral wrote:

I can take this task up.

See https://www.mediawiki.org/wiki/New_Developers#Communication_tips :)

gerritbot added a comment.Fri, Feb 6, 6:46 PM

Change #1237530 abandoned by Complicatedintegral:

[mediawiki/core@master] Hungarian: Fix translation of img_upright

Reason:

Patch not required

https://gerrit.wikimedia.org/r/1237530

Complicatedintegral added a comment.Fri, Feb 6, 6:48 PM

@Aklapper Got it, sorry for the hassle.

gerritbot added a comment.Fri, Feb 6, 7:11 PM

Change #1237530 restored by Complicatedintegral:

[mediawiki/core@master] Hungarian: Fix translation of img_upright

https://gerrit.wikimedia.org/r/1237530

gerritbot added a comment.Fri, Feb 6, 8:05 PM

Change #1237580 had a related patch set uploaded (by Complicatedintegral; author: Complicatedintegral):

[mediawiki/core@master] Hungarian: Fix img_upright translation while maintaining backward compatibility

https://gerrit.wikimedia.org/r/1237580

gerritbot added a comment.Sat, Feb 7, 2:26 AM

Change #1237580 abandoned by Complicatedintegral:

[mediawiki/core@master] Hungarian: Fix img_upright translation while maintaining backward compatibility

Reason:

Had to soft reset git before updating my new patch which altered the Change-Id, I had already been working on this bug under a different Change-Id.

https://gerrit.wikimedia.org/r/1237580

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits