Multi colon escape appears to ignore noinclude tags
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jonesey95
	Jun 8 2023, 3:31 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.org/w/index.php?title=Template:Userxx&oldid=1158867314

What happens?:

See three multi colon escape errors listed

What should have happened instead?:

No errors should have been listed. There does not appear to be a multi colon escape problem here. Copying the text to Special:ExpandTemplates results in zero errors, although that page does not always show Linter errors properly.

Was there a recent change to the multi colon escape detection code that caused this error to appear on this page? The Linter error list for this error was completely clear on en.WP until this page suddenly popped up on it (before my edit to remove a space). If there was not a change, why didn't the page appear on the error list when it was edited on 14 September 2022?‎

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Fix noinclude in templatearg default value	mediawiki/services/parsoid	master	+8 -3

Customize query in gerrit

Related Objects

Mentioned Here: T373776: Parsoid does not correctly render <noinclude> if used with templates

Event Timeline

Jonesey95 created this task.Jun 8 2023, 3:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2023, 3:31 PM

why didn't the page appear on the error list when it was edited on 14 September 2022?‎

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/908910

Thanks for that. It appears that a bug fix has revealed this new bug. That's software development for you.

Change 928691 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Fix noinclude in templatearg default value

https://gerrit.wikimedia.org/r/928691

gerritbot added a project: Patch-For-Review.Jun 9 2023, 12:43 AM

The bogus lint is just a symptom of Parsoid not rendering this correctly,
https://en.wikipedia.org/api/rest_v1/page/html/Template:Userxx/1158867314

Arlolra claimed this task.Jun 9 2023, 12:45 AM

Arlolra triaged this task as Medium priority.

Arlolra moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.

Arlolra added projects: Parsoid, Content-Transform-Team-WIP.

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.

MSantos added a project: Essential-Work.Jun 19 2023, 11:31 AM

MSantos moved this task from In Progress to Backlog on the Content-Transform-Team-WIP board.Nov 13 2023, 4:28 PM

ihurbain removed a project: Content-Transform-Team-WIP.Apr 18 2024, 2:24 PM

Arlolra reassigned this task from Arlolra to ABreault-WMF.Jun 6 2024, 3:00 PM

This was fixed by T373776

https://en.wikipedia.org/api/rest_v1/page/html/Template:Userxx/1158867314 looks good now

So does
https://en.wikipedia.org/wiki/Template:Userxx?useparsoid=1
vs
https://en.wikipedia.org/wiki/Template:Userxx?useparsoid=0

And https://en.wikipedia.org/wiki/Template:Userxx?action=info doesn't show any lint errors.

Change #928691 abandoned by Arlolra:

[mediawiki/services/parsoid@master] [WIP] Fix noinclude in templatearg default value

Reason:

In favour of Ied9ed72be7bbff6d7f323109bc0043f1aa0f4b70