Page MenuHomePhabricator
Create Task
Maniphest T338489

Section images: Pressing Esc during onboarding freezes the UI
Open, LowestPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • start a suggested section image task on desktop with the onboarding-needed user preference (growthexperiments-addsectionimage-onboarding) enabled
  • press Esc on the last onboarding screen

What happens?:
The "Are you sure you want to leave?" dialog comes up. The page becomes unresponsive (due to some overlay z-index confusion, I think). No error is logged.

What should have happened instead?:
Onboarding is skipped. (This does happen on onboarding screens other than the last.)

Software version (skip for WMF-hosted wikis like Wikipedia):
Tested locally on master.

Other information (browser name/version, screenshots, etc.):
Didn't test other task types but I expect it isn't actually specific to section images.

Screenshot Capture - 2023-06-08 - 19-35-34.png (941×1 px, 296 KB)

Event Timeline

Tgr created this task.Jun 8 2023, 5:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2023, 5:32 PM
Tgr updated the task description. (Show Details)Jun 8 2023, 5:35 PM
Tgr attached a referenced file: F37098288: Screenshot Capture - 2023-06-08 - 19-35-34.png. (Show Details)
Tgr updated the task description. (Show Details)Jun 8 2023, 5:38 PM
KStoller-WMF moved this task from Backlog to Post MVP Pilot Release on the Section-Level-Image-Suggestions board.Jun 8 2023, 6:37 PM
KStoller-WMF subscribed.
• KMorgan-WMF claimed this task.Jun 20 2023, 1:04 PM
KStoller-WMF added a project: Growth-Team (Sprint 0 (Growth Team)).Jun 20 2023, 3:26 PM
KStoller-WMF triaged this task as Medium priority.Jun 23 2023, 4:25 PM
KStoller-WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
• KMorgan-WMF added a comment.Jul 11 2023, 2:32 PM

Tested this again and am not able to replicate locally in Chrome or Firefox. @Tgr / @KStoller-WMF can you confirm it's still an issue?

https://streamable.com/3a2fl0 (at the end I hit escape, close the question dialog then hit escape again)

KStoller-WMF added a comment.Jul 13 2023, 4:42 PM

Kayla and I chatted about this at our 1:1, and I screen shared what I was able to reproduce on Spanish Wikipedia (testing on desktop / Chrome Version 114.0.5735.198).

I wasn't able to replicate the exact bug documented, but the behavior is somewhat buggy:

  1. From homepage: https://es.wikipedia.beta.wmflabs.org/w/index.php?title=Especial:P%C3%A1gina_inicial
  2. navigate to a section-level image task
  3. click through to the fourth onboarding screen
  4. press Esc on the last onboarding screen
  5. Select "Discard edits"

What happens:
Onboarding screen remains and you have to press Esc or "Get started" to navigate away.

What should have happened instead?:
If you select "Discard edits" I would expect the onboarding to get dismissed and to navigate back to the article view / rather than the edit view.

KStoller-WMF added a comment.Sep 5 2023, 9:00 PM

@KMorgan-WMF, any update on this work? Will you move this to "In Progress" on the Phabricator Workboard if you are working on this?

KStoller-WMF moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 19 2023, 5:04 PM
Sgs subscribed.Sep 21 2023, 3:54 PM

I think the issue is the onboarding modal is loosing its focus on the last step for some reason and then the ESC hit is handled by VE instead of the modal, popping up the "Discard edits" instead of dismissing the onbaording. cc @KMorgan-WMF.

KStoller-WMF removed • KMorgan-WMF as the assignee of this task.Oct 3 2023, 5:10 PM
KStoller-WMF moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
KStoller-WMF added a subscriber: • KMorgan-WMF.
KStoller-WMF lowered the priority of this task from Medium to Lowest.Oct 11 2023, 9:41 PM
KStoller-WMF moved this task from Sprint 0 (Growth Team) to Backlog on the Growth-Team board.
KStoller-WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits