Page MenuHomePhabricator

Section images: Pressing Esc during onboarding freezes the UI
Open, LowestPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • start a suggested section image task on desktop with the onboarding-needed user preference (growthexperiments-addsectionimage-onboarding) enabled
  • press Esc on the last onboarding screen

What happens?:
The "Are you sure you want to leave?" dialog comes up. The page becomes unresponsive (due to some overlay z-index confusion, I think). No error is logged.

What should have happened instead?:
Onboarding is skipped. (This does happen on onboarding screens other than the last.)

Software version (skip for WMF-hosted wikis like Wikipedia):
Tested locally on master.

Other information (browser name/version, screenshots, etc.):
Didn't test other task types but I expect it isn't actually specific to section images.

Screenshot Capture - 2023-06-08 - 19-35-34.png (941×1 px, 296 KB)

Event Timeline

Tested this again and am not able to replicate locally in Chrome or Firefox. @Tgr / @KStoller-WMF can you confirm it's still an issue? (at the end I hit escape, close the question dialog then hit escape again)

Kayla and I chatted about this at our 1:1, and I screen shared what I was able to reproduce on Spanish Wikipedia (testing on desktop / Chrome Version 114.0.5735.198).

I wasn't able to replicate the exact bug documented, but the behavior is somewhat buggy:

  1. From homepage:
  2. navigate to a section-level image task
  3. click through to the fourth onboarding screen
  4. press Esc on the last onboarding screen
  5. Select "Discard edits"

What happens:
Onboarding screen remains and you have to press Esc or "Get started" to navigate away.

What should have happened instead?:
If you select "Discard edits" I would expect the onboarding to get dismissed and to navigate back to the article view / rather than the edit view.

@KMorgan-WMF, any update on this work? Will you move this to "In Progress" on the Phabricator Workboard if you are working on this?

I think the issue is the onboarding modal is loosing its focus on the last step for some reason and then the ESC hit is handled by VE instead of the modal, popping up the "Discard edits" instead of dismissing the onbaording. cc @KMorgan-WMF.

KStoller-WMF lowered the priority of this task from Medium to Lowest.Oct 11 2023, 9:41 PM
KStoller-WMF moved this task from Sprint 0 (Growth Team) to Backlog on the Growth-Team board.