Page MenuHomePhabricator
Create Task
Maniphest T338933

Remove repository prefixes from RdfBuilderTest data
Closed, ResolvedPublic
Actions

Description

RdfBuilderTest contains tests dealing with non-local entities. At least some of these tests are useful for the structured data for Commons functionality, but a lot of it still uses the unused repository prefixes in entity IDs in the test data.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/929366/2 "blindly" removes some of the prefixes to unblock shipping the patch that disallows repository prefixes in entity IDs, but there are still a lot of other tests and fixture files that should be cleaned up. This work could benefit from someone who knows their way around these RdfBuilder tests to help with the cleanup.

Details

SubjectRepoBranchLines +/-
(Re-)added RDF tests for properties that are from the "local" Wikibasemediawiki/extensions/Wikibasemaster+487 -281
Removed invalid "prefixed" property IDs from RdfBuilderTestDatamediawiki/extensions/Wikibasemaster+0 -0
Removed RdfBuilderTestData::getTestProperties_noPrefixedIdsmediawiki/extensions/Wikibasemaster+1 -20
Removed no longer needed RDF test datamediawiki/extensions/Wikibasemaster+34 -1 K
Removed EntityId "local part" from RdfVocabularymediawiki/extensions/Wikibasemaster+1 -4
Removed references to getLocalPart in TermsRdfBuilderTestmediawiki/extensions/Wikibasemaster+3 -3
Remove tests relying on entity ID prefixesmediawiki/extensions/Wikibasemaster+14 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jun 13 2023, 9:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2023, 9:54 AM
gerritbot added a comment.Jun 13 2023, 9:55 AM

Change 929366 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Remove tests relying on entity ID prefixes

https://gerrit.wikimedia.org/r/929366

gerritbot added a project: Patch-For-Review.Jun 13 2023, 9:55 AM
gerritbot added a comment.Jun 13 2023, 10:00 PM

Change 929366 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove tests relying on entity ID prefixes

https://gerrit.wikimedia.org/r/929366

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 13 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 13 2023, 10:10 PM
gerritbot added a comment.Jun 16 2023, 8:53 PM

Change 930872 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed references to getLocalPart in TermsRdfBuilderTest

https://gerrit.wikimedia.org/r/930872

gerritbot added a project: Patch-For-Review.Jun 16 2023, 8:53 PM

Change 930873 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from RdfVocabulary

https://gerrit.wikimedia.org/r/930873

gerritbot added a comment.Jun 16 2023, 8:53 PM

Change 930874 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed invalid "prefixed" property IDs from RdfBuilderTestData

https://gerrit.wikimedia.org/r/930874

gerritbot added a comment.Jun 16 2023, 8:53 PM

Change 930875 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed RdfBuilderTestData::getTestProperties_noPrefixedIds

https://gerrit.wikimedia.org/r/930875

gerritbot added a comment.Jun 16 2023, 8:53 PM

Change 930876 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] WIP Removed no longer needed RDF test data

https://gerrit.wikimedia.org/r/930876

gerritbot added a comment.Jun 19 2023, 9:40 PM

Change 931323 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] (Re-)added RDF tests for properties that are from the "local" Wikibase

https://gerrit.wikimedia.org/r/931323

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 32); removed Wikibase Product Platform (v1) (Sprint 31).Jun 28 2023, 7:55 AM
gerritbot added a comment.Jul 10 2023, 10:33 AM

Change 930872 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed references to getLocalPart in TermsRdfBuilderTest

https://gerrit.wikimedia.org/r/930872

gerritbot added a comment.Jul 10 2023, 10:33 AM

Change 930873 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from RdfVocabulary

https://gerrit.wikimedia.org/r/930873

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jul 10 2023, 11:00 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 33); removed Wikibase Product Platform (v1) (Sprint 32).Jul 11 2023, 7:37 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1); removed Wikibase Product Platform (v1) (Sprint 33).Jul 11 2023, 9:35 AM
gerritbot added a comment.Jul 17 2023, 3:19 PM

Change 930875 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed RdfBuilderTestData::getTestProperties_noPrefixedIds

https://gerrit.wikimedia.org/r/930875

gerritbot added a comment.Jul 17 2023, 3:19 PM

Change 930876 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed no longer needed RDF test data

https://gerrit.wikimedia.org/r/930876

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 17 2023, 4:00 PM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP; removed Wikibase Product Platform (v1).Aug 2 2023, 3:18 PM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Tech backlog on the Wikibase Product Platform Team WPP board.
gerritbot added a comment.Sep 4 2023, 12:39 PM

Change 930874 abandoned by WMDE-leszek:

[mediawiki/extensions/Wikibase@master] Removed invalid "prefixed" property IDs from RdfBuilderTestData

Reason:

change happened in I46b7eff7cfe3b472b58e9a45f2f217dc70fafbe7

https://gerrit.wikimedia.org/r/930874

gerritbot added a comment.Sep 7 2023, 8:34 AM

Change 931323 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] (Re-)added RDF tests for properties that are from the "local" Wikibase

https://gerrit.wikimedia.org/r/931323

WMDE-leszek closed this task as Resolved.Sep 7 2023, 8:35 AM

Seems like it has been cleaned up sufficiently.

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2023, 9:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits