Page MenuHomePhabricator
Create Task
Maniphest T291823

Remove "old federation" methods from EntityId
Open, Needs TriagePublic
Actions

Description

Although they are used in a few places, these methods likely no longer necessary. This includes

  • EntityId:
    • EntityId::getLocalPart
    • EntityId::getRepositoryName
  • SerializableEntityId:
    • SerializableEntityId::splitSerialization
    • SerializableEntityId::joinSerialization
    • SerializableEntityId::isForeign
  • corresponding methods in concrete entity ID classes: ItemId, PropertyId, LexemeId/FormId/SenseId, MediaInfoId

Acceptance Criteria: 🏕️🌟(September 2021):

  • all calls to those methods are removed
  • those methods are gone, as well as all private/protected methods that become unused with this

Details

SubjectRepoBranchLines +/-
Removed reference to repositoryName and localPart in ID classesmediawiki/extensions/WikibaseLexememaster+0 -17
Assert that foreign entity IDs are no longer supportedmediawiki/extensions/WikibaseLexememaster+2 -0
Removed RepositoryNameAssertmediawiki/extensions/Wikibasemaster+0 -162
Assert that foreign entity IDs are no longer supportesmediawiki/extensions/WikibaseMediaInfomaster+2 -0
Added a test confirming Wikibase accepts incorrect IDs with a "prefix"mediawiki/extensions/Wikibasemaster+44 -0
Dropped "repository name" and "local part" from EntityIdmediawiki/extensions/Wikibasemaster+0 -95
Removed repositoryName and localPart from MediaInfoIdmediawiki/extensions/WikibaseMediaInfomaster+0 -6
Stopped using EntityId::getLocalPart in DescriptionLookupTestmediawiki/extensions/Wikibasemaster+1 -1
Stop setting repositoryName and localPartmediawiki/extensions/WikibaseMediaInfomaster+6 -3
Stop calling getRepositoryName and getLocalPart in testsmediawiki/extensions/WikibaseLexememaster+0 -15
Stop setting repositoryName and localPartmediawiki/extensions/WikibaseLexememaster+13 -6
Removed the use of EntityId::localPart from ID classesmediawiki/extensions/WikibaseLexememaster+4 -4
Removed SerializableEntityId::splitSerializationmediawiki/extensions/Wikibasemaster+0 -68
Removed SerializableEntityId::joinSerializationmediawiki/extensions/Wikibasemaster+0 -44
DM: Removed the use of split/join Serialization from Item/Property IDmediawiki/extensions/Wikibasemaster+14 -14
Removed the use of split/join Serialization in LexemeId and FormIdmediawiki/extensions/WikibaseLexememaster+4 -9
Formally disallowed using colons/prefixes in the Item/Property IDmediawiki/extensions/Wikibasemaster+12 -36
Confirm it is impossible to have colons in Lexeme IDsmediawiki/extensions/WikibaseLexememaster+1 -1
Temporarily disabled tests involving prefixed Lexeme IDsmediawiki/extensions/WikibaseLexememaster+1 -1
Removed the usage of splitSerialization from DispatchingIdParsermediawiki/extensions/Wikibasemaster+19 -10
Removed no longer used newFromRepositoryAndNumber from ItemId/PropertyIdmediawiki/extensions/Wikibasemaster+0 -61
Simplify EntityIdComposer usage codemediawiki/extensions/WikibaseLexememaster+1 -4
Removed unused repository name from EntityIdComposermediawiki/extensions/Wikibasemaster+2 -8
Simplify EntityIdComposer usage codemediawiki/extensions/WikibaseMediaInfomaster+3 -15
Drop not needed EntityIdComposer::composeEntityId argmediawiki/extensions/WikibaseMediaInfomaster+0 -5
Removed (Serializable)EntityId::isForeignmediawiki/extensions/Wikibasemaster+0 -15
Prepare for dropping "repo prefix" from EntityComposermediawiki/extensions/WikibaseLexememaster+5 -7
Prepare removal of the unused repository name concept from EntityIdComposermediawiki/extensions/Wikibasemaster+40 -35
Prepare for dropping "repo prefix" from EntityComposermediawiki/extensions/WikibaseMediaInfomaster+18 -21
Removed usages of EntityId::isForeignmediawiki/extensions/WikibaseLexememaster+0 -7
Simplified RepoLinkerTest namemediawiki/extensions/Wikibasemaster+1 -1
Remove incorrect repo prefix reference in RepoLinkermediawiki/extensions/Wikibasemaster+0 -0
Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMappingmediawiki/extensions/WikibaseLexemeCirrusSearchmaster+2 -2
Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMappingmediawiki/extensions/WikibaseCirrusSearchmaster+2 -2
Simplified "is of known entity type" checks in EntityIdSearchHelper, part 2mediawiki/extensions/Wikibasemaster+3 -7
Removed no longer used WikibaseRepo::getEntityTypeToRepositoryMappingmediawiki/extensions/Wikibasemaster+0 -93
Simplified "is of known entity type" checks in EntityIdSearchHelpermediawiki/extensions/Wikibasemaster+14 -30
Adopted a simplified constructor of Wikibase's SearchEntityIdHelpermediawiki/extensions/WikibaseLexememaster+3 -3
Removed unused references to "repository prefixes" from SearchHelpermediawiki/extensions/Wikibasemaster+1 -31
Removed EntityId "local part" from RepoLinkermediawiki/extensions/Wikibasemaster+1 -1
Removed EntityId "local part" from ConceptUriSearchHelpermediawiki/extensions/Wikibasemaster+1 -1
Removed EntityId "local part" from WikiPageEntityMetaDataLookupmediawiki/extensions/Wikibasemaster+2 -5
Removed the incorrect mention of "entity repository" in an exceptionmediawiki/extensions/Wikibasemaster+1 -1
Removed EntityId "local part" from ...PageTableEntityQuerymediawiki/extensions/Wikibasemaster+5 -5
Removed EntityId "local part" from RdfVocabularymediawiki/extensions/Wikibasemaster+1 -4
Removed references to getLocalPart in TermsRdfBuilderTestmediawiki/extensions/Wikibasemaster+3 -3
Drop support for repo names in entity IDsmediawiki/extensions/Wikibasemaster+28 -114
Remove SerializableEntityId::splitSerialization usagemediawiki/extensions/WikibaseMediaInfomaster+4 -8
Remove tests relying on foreign entity IDsmediawiki/extensions/Wikibasemaster+7 -41
Remove tests relying on entity ID prefixesmediawiki/extensions/Wikibasemaster+14 -14
Rewrite GetEntitiesTest to stop relying on foreign entity IDsmediawiki/extensions/Wikibasemaster+16 -12
Remove PrefixMappingEntityIdParser and factorymediawiki/extensions/Wikibasemaster+0 -389
Remove tests relying on foreign entity IDsmediawiki/extensions/WikibaseLexememaster+10 -27
Remove repo prefixes from LinkFormatter testmediawiki/extensions/Wikibasemaster+30 -18
Remove DispatchingEntityLookupmediawiki/extensions/Wikibasemaster+25 -328
Remove tests relying on foreign entity IDsmediawiki/extensions/WikibaseMediaInfomaster+0 -1
Remove tests relying on foreign entity IDsmediawiki/extensions/WikibaseLexememaster+5 -13
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
hashar lowered the priority of this task from Unbreak Now! to Needs Triage.Jul 6 2023, 4:32 PM

Dropping Unbreak Now! priority since I have managed to fix the issue by editing Wikidata items :]

Lucas_Werkmeister_WMDE added a comment.Jul 7 2023, 9:24 AM

I think that’s the correct fix, yes. Thanks @hashar! (For the record, the second edited item is https://www.wikidata.org/wiki/Q746525 – I think you accidentally pasted the same link twice.)

Lucas_Werkmeister_WMDE added a comment.Jul 7 2023, 9:25 AM

Also, it’s possible there are more items with IDs that are broken that way, but I don’t think it’s realistically possible for us to search for them – logstash is probably the best way. Feel free to mention any other occurrences of this error here.

gerritbot added a comment.Jul 10 2023, 10:33 AM

Change 930872 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed references to getLocalPart in TermsRdfBuilderTest

https://gerrit.wikimedia.org/r/930872

gerritbot added a comment.Jul 10 2023, 10:33 AM

Change 930873 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from RdfVocabulary

https://gerrit.wikimedia.org/r/930873

gerritbot added a comment.Jul 10 2023, 10:51 AM

Change 933105 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from ...PageTableEntityQuery

https://gerrit.wikimedia.org/r/933105

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jul 10 2023, 11:00 AM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 33); removed Wikibase Product Platform (v1) (Sprint 32).Jul 11 2023, 7:37 AM
WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 33) board.Jul 11 2023, 9:32 AM
WMDE-leszek moved this task from Doing to To Do on the Wikibase Product Platform (v1) (Sprint 33) board.
WMDE-leszek edited projects, added Wikibase Product Platform (v1); removed Wikibase Product Platform (v1) (Sprint 33).Jul 11 2023, 9:36 AM
hashar added a comment.Jul 11 2023, 9:39 AM
In T291823#8996830, @Lucas_Werkmeister_WMDE wrote:

Also, it’s possible there are more items with IDs that are broken that way, but I don’t think it’s realistically possible for us to search for them – logstash is probably the best way. Feel free to mention any other occurrences of this error here.

That is the part I wasn't sure. Looking for this task number T291823 in logstash over the last 7 days looks like the ones I have fixed were the only occurrences :-] So I guess we are all set.

gerritbot added a comment.Jul 11 2023, 1:01 PM

Change 933107 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed the incorrect mention of "entity repository" in an exception

https://gerrit.wikimedia.org/r/933107

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 11 2023, 2:00 PM
gerritbot added a comment.Jul 11 2023, 2:19 PM

Change 933104 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from WikiPageEntityMetaDataLookup

https://gerrit.wikimedia.org/r/933104

gerritbot added a comment.Jul 11 2023, 2:20 PM

Change 933106 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from RepoLinker

https://gerrit.wikimedia.org/r/933106

gerritbot added a comment.Jul 11 2023, 2:21 PM

Change 933103 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed EntityId "local part" from ConceptUriSearchHelper

https://gerrit.wikimedia.org/r/933103

gerritbot added a comment.Jul 12 2023, 11:04 AM

Change 930861 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed unused references to "repository prefixes" from SearchHelper

https://gerrit.wikimedia.org/r/930861

gerritbot added a comment.Jul 13 2023, 8:58 AM

Change 930862 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplified "is of known entity type" checks in EntityIdSearchHelper

https://gerrit.wikimedia.org/r/930862

gerritbot added a comment.Jul 13 2023, 8:58 AM

Change 930942 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Adopted a simplified constructor of Wikibase's SearchEntityIdHelper

https://gerrit.wikimedia.org/r/930942

gerritbot added a comment.Jul 13 2023, 8:59 AM

Change 931273 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplified "is of known entity type" checks in EntityIdSearchHelper, part 2

https://gerrit.wikimedia.org/r/931273

gerritbot added a comment.Jul 13 2023, 8:59 AM

Change 930863 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed no longer used WikibaseRepo::getEntityTypeToRepositoryMapping

https://gerrit.wikimedia.org/r/930863

LucasWerkmeister mentioned this in T341837: Entity search broken on Beta Wikidata: Call to undefined method Wikibase\\Repo\\WikibaseRepo::getEntityTypeToRepositoryMapping().Jul 13 2023, 11:18 PM
gerritbot added a comment.Jul 14 2023, 6:14 AM

Change 938028 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseCirrusSearch@master] Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMapping

https://gerrit.wikimedia.org/r/938028

gerritbot added a comment.Jul 14 2023, 8:04 AM

Change 938028 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMapping

https://gerrit.wikimedia.org/r/938028

gerritbot added a comment.Jul 14 2023, 11:15 AM

Change 938225 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMapping

https://gerrit.wikimedia.org/r/938225

gerritbot added a comment.Jul 14 2023, 12:04 PM

Change 938225 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMapping

https://gerrit.wikimedia.org/r/938225

WMDE-leszek mentioned this in rEWLCc2fbd23a32c0: Removed reference to delete WikibaseRepo::getEntityTypeToRepositoryMapping.Jul 14 2023, 1:08 PM
hashar unsubscribed.Jul 17 2023, 11:16 AM
brennen unsubscribed.Jul 17 2023, 4:52 PM
gerritbot added a comment.Jul 24 2023, 7:44 PM

Change 940993 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Removed usages of EntityId::isForeign

https://gerrit.wikimedia.org/r/940993

gerritbot added a comment.Jul 25 2023, 8:56 AM

Change 941366 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Prepare for dropping "repo prefix" from EntityComposer

https://gerrit.wikimedia.org/r/941366

gerritbot added a comment.Jul 25 2023, 9:04 AM

Change 941369 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseMediaInfo@master] Prepare for dropping "repo prefix" from EntityComposer

https://gerrit.wikimedia.org/r/941369

gerritbot added a comment.Jul 25 2023, 9:31 PM

Change 941524 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed unused repository name from EntityIdComposer

https://gerrit.wikimedia.org/r/941524

gerritbot added a comment.Jul 25 2023, 9:32 PM

Change 941525 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseMediaInfo@master] Simplify EntityIdComposer usage code

https://gerrit.wikimedia.org/r/941525

gerritbot added a comment.Jul 25 2023, 9:32 PM

Change 941526 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Simplify EntityIdComposer usage code

https://gerrit.wikimedia.org/r/941526

gerritbot added a comment.Jul 31 2023, 8:34 PM

Change 943636 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed no longer used newFromRepositoryAndNumber from ItemId/PropertyId

https://gerrit.wikimedia.org/r/943636

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP; removed Wikibase Product Platform (v1).Aug 2 2023, 3:20 PM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Tech backlog on the Wikibase Product Platform Team WPP board.
gerritbot added a comment.Aug 6 2023, 11:08 AM

Change 930809 abandoned by Umherirrender:

[mediawiki/extensions/Wikibase@master] Remove incorrect repo prefix reference in RepoLinker

Reason:

Done with Ib4d84bdd62fb7e4c5c33a6565e5ab5b597e4454f

https://gerrit.wikimedia.org/r/930809

gerritbot added a comment.Aug 6 2023, 11:36 AM

Change 930810 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplified RepoLinkerTest name

https://gerrit.wikimedia.org/r/930810

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Aug 6 2023, 12:00 PM
gerritbot added a comment.Aug 9 2023, 8:00 AM

Change 941369 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Prepare for dropping "repo prefix" from EntityComposer

https://gerrit.wikimedia.org/r/941369

gerritbot added a comment.Aug 9 2023, 8:02 AM

Change 940993 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Removed usages of EntityId::isForeign

https://gerrit.wikimedia.org/r/940993

gerritbot added a comment.Aug 9 2023, 8:03 AM

Change 941366 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Prepare for dropping "repo prefix" from EntityComposer

https://gerrit.wikimedia.org/r/941366

gerritbot added a comment.Aug 9 2023, 8:47 AM

Change 933110 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Prepare removal of the unused repository name concept from EntityIdComposer

https://gerrit.wikimedia.org/r/933110

gerritbot added a comment.Aug 9 2023, 9:29 AM

Change 933108 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed (Serializable)EntityId::isForeign

https://gerrit.wikimedia.org/r/933108

gerritbot added a comment.Aug 9 2023, 2:14 PM

Change 947360 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily build MediaInfoId without EntityIdComposer

https://gerrit.wikimedia.org/r/947360

gerritbot added a comment.Aug 9 2023, 8:51 PM

Change 947360 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Drop not needed EntityIdComposer::composeEntityId arg

https://gerrit.wikimedia.org/r/947360

gerritbot added a comment.Aug 10 2023, 7:58 AM

Change 941524 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed unused repository name from EntityIdComposer

https://gerrit.wikimedia.org/r/941524

gerritbot added a comment.Aug 10 2023, 7:58 AM

Change 941525 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Simplify EntityIdComposer usage code

https://gerrit.wikimedia.org/r/941525

gerritbot added a comment.Aug 10 2023, 8:18 AM

Change 941526 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Simplify EntityIdComposer usage code

https://gerrit.wikimedia.org/r/941526

gerritbot added a comment.Aug 10 2023, 8:42 AM

Change 943636 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed no longer used newFromRepositoryAndNumber from ItemId/PropertyId

https://gerrit.wikimedia.org/r/943636

gerritbot added a comment.Aug 11 2023, 5:12 PM

Change 948168 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Formally disallowed using colons/prefixes in the Item/Property ID

https://gerrit.wikimedia.org/r/948168

gerritbot added a comment.Aug 11 2023, 5:12 PM

Change 948169 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Temporarily disabled tests involving prefixed Lexeme IDs

https://gerrit.wikimedia.org/r/948169

gerritbot added a comment.Aug 11 2023, 5:12 PM

Change 948170 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Confirm it is impossible to have colons in Lexeme IDs

https://gerrit.wikimedia.org/r/948170

gerritbot added a comment.Aug 25 2023, 10:20 AM

Change 952323 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed the usage of splitSerialization from DispatchingIdParser

https://gerrit.wikimedia.org/r/952323

gerritbot added a comment.Aug 25 2023, 11:23 AM

Change 952358 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] DM: Removed the use of split/join Serialization from Item/Property ID

https://gerrit.wikimedia.org/r/952358

gerritbot added a comment.Aug 25 2023, 11:31 AM

Change 952359 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Removed the use of split/join Serialization in LexemeId and FormId

https://gerrit.wikimedia.org/r/952359

gerritbot added a comment.Aug 25 2023, 1:43 PM

Change 952323 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed the usage of splitSerialization from DispatchingIdParser

https://gerrit.wikimedia.org/r/952323

gerritbot added a comment.Aug 28 2023, 8:32 AM

Change 952785 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed SerializableEntityId::joinSerialization

https://gerrit.wikimedia.org/r/952785

gerritbot added a comment.Aug 28 2023, 8:32 AM

Change 952806 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed SerializableEntityId::splitSerialization

https://gerrit.wikimedia.org/r/952806

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 30 2023, 3:01 AM
gerritbot added a comment.Aug 31 2023, 11:26 AM

Change 953993 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Dropped "repository name" and "local part" from EntityId

https://gerrit.wikimedia.org/r/953993

gerritbot added a comment.Aug 31 2023, 2:47 PM

Change 948169 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Temporarily disabled tests involving prefixed Lexeme IDs

https://gerrit.wikimedia.org/r/948169

gerritbot added a comment.Aug 31 2023, 2:50 PM

Change 948168 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Formally disallowed using colons/prefixes in the Item/Property ID

https://gerrit.wikimedia.org/r/948168

gerritbot added a comment.Aug 31 2023, 3:01 PM

Change 948170 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Confirm it is impossible to have colons in Lexeme IDs

https://gerrit.wikimedia.org/r/948170

gerritbot added a comment.Aug 31 2023, 3:05 PM

Change 952359 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Removed the use of split/join Serialization in LexemeId and FormId

https://gerrit.wikimedia.org/r/952359

gerritbot added a comment.Aug 31 2023, 7:11 PM

Change 952358 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Removed the use of split/join Serialization from Item/Property ID

https://gerrit.wikimedia.org/r/952358

gerritbot added a comment.Aug 31 2023, 7:11 PM

Change 952785 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed SerializableEntityId::joinSerialization

https://gerrit.wikimedia.org/r/952785

gerritbot added a comment.Aug 31 2023, 7:14 PM

Change 952806 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed SerializableEntityId::splitSerialization

https://gerrit.wikimedia.org/r/952806

gerritbot added a comment.Aug 31 2023, 8:32 PM

Change 954127 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Removed the use of EntityId::localPart from ID classes

https://gerrit.wikimedia.org/r/954127

gerritbot added a comment.Aug 31 2023, 8:33 PM

Change 954128 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Stop calling getRepositoryName and getLocalPart in tests

https://gerrit.wikimedia.org/r/954128

gerritbot added a comment.Aug 31 2023, 8:33 PM

Change 954129 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Stop setting repositoryName and localPart

https://gerrit.wikimedia.org/r/954129

gerritbot added a comment.Aug 31 2023, 8:49 PM

Change 954133 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Removed RepositoryNameAssert

https://gerrit.wikimedia.org/r/954133

gerritbot added a comment.Aug 31 2023, 9:29 PM

Change 954136 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseMediaInfo@master] Stop setting repositoryName and localPart

https://gerrit.wikimedia.org/r/954136

gerritbot added a comment.Aug 31 2023, 9:29 PM

Change 954137 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseMediaInfo@master] Removed repositoryName and localPart from MediaInfoId

https://gerrit.wikimedia.org/r/954137

gerritbot added a comment.Aug 31 2023, 9:30 PM

Change 954138 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/Wikibase@master] Stopped using EntityId::getLocalPart in DescriptionLookupTest

https://gerrit.wikimedia.org/r/954138

gerritbot added a comment.Sep 1 2023, 8:31 AM

Change 954127 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Removed the use of EntityId::localPart from ID classes

https://gerrit.wikimedia.org/r/954127

gerritbot added a comment.Sep 1 2023, 8:31 AM

Change 954128 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Stop calling getRepositoryName and getLocalPart in tests

https://gerrit.wikimedia.org/r/954128

gerritbot added a comment.Sep 1 2023, 8:32 AM

Change 954129 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Stop setting repositoryName and localPart

https://gerrit.wikimedia.org/r/954129

gerritbot added a comment.Sep 1 2023, 8:57 AM

Change 954136 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Stop setting repositoryName and localPart

https://gerrit.wikimedia.org/r/954136

gerritbot added a comment.Sep 1 2023, 9:16 AM

Change 954138 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stopped using EntityId::getLocalPart in DescriptionLookupTest

https://gerrit.wikimedia.org/r/954138

gerritbot added a comment.Sep 1 2023, 9:17 AM

Change 953993 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Dropped "repository name" and "local part" from EntityId

https://gerrit.wikimedia.org/r/953993

gerritbot added a comment.Sep 1 2023, 9:17 AM

Change 954137 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Removed repositoryName and localPart from MediaInfoId

https://gerrit.wikimedia.org/r/954137

gerritbot added a comment.Sep 1 2023, 12:45 PM

Change 929422 abandoned by WMDE-leszek:

[mediawiki/extensions/Wikibase@master] Added a test confirming Wikibase accepts incorrect IDs with a "prefix"

Reason:

Fails as expected. Bug removed

https://gerrit.wikimedia.org/r/929422

gerritbot added a comment.Sep 1 2023, 1:02 PM

Change 927726 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Assert that foreign entity IDs are no longer supportes

https://gerrit.wikimedia.org/r/927726

gerritbot added a comment.Sep 3 2023, 7:43 PM

Change 954399 had a related patch set uploaded (by WMDE-leszek; author: WMDE-leszek):

[mediawiki/extensions/WikibaseLexeme@master] Removed reference to repositoryName and localPart in ID classes

https://gerrit.wikimedia.org/r/954399

gerritbot added a comment.Sep 4 2023, 12:51 PM

Change 954133 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Removed RepositoryNameAssert

https://gerrit.wikimedia.org/r/954133

gerritbot added a comment.Sep 4 2023, 12:52 PM

Change 954399 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Removed reference to repositoryName and localPart in ID classes

https://gerrit.wikimedia.org/r/954399

gerritbot added a comment.Sep 4 2023, 12:52 PM

Change 927707 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Assert that foreign entity IDs are no longer supported

https://gerrit.wikimedia.org/r/927707

WMDE-leszek closed subtask T338933: Remove repository prefixes from RdfBuilderTest data as Resolved.Sep 7 2023, 8:35 AM
darthmon_wmde removed projects: Wikidata, [DEPRECATED] wdwb-tech.Sep 13 2023, 11:32 AM
Lucas_Werkmeister_WMDE mentioned this in T349982: [REPO][SW] Wikibase\DataModel\Services\Lookup\EntityLookupException: Failed to unserialize the content object..Oct 30 2023, 9:48 AM
In T291823#8996830, @Lucas_Werkmeister_WMDE wrote:

Also, it’s possible there are more items with IDs that are broken that way, but I don’t think it’s realistically possible for us to search for them – logstash is probably the best way. Feel free to mention any other occurrences of this error here.

A wd:Q100 in a lexeme lexical category is causing this error as soon as you try to view the old revision or a history / contributions containing it: T349982: [REPO][SW] Wikibase\DataModel\Services\Lookup\EntityLookupException: Failed to unserialize the content object.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits