Page MenuHomePhabricator
Create Task
Maniphest T339097

Add 'view diff' & 'edit the latest revision' links to editingold message
Open, Needs TriagePublicFeature
Actions

Description

Feature summary (what you would like to be able to do and where):
Add 'view diff' & 'edit the latest revision' links to MediaWiki:editingold.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Used when editing an out-of-date revision of a page (https://www.mediawiki.org/w/index.php?title=Extension_talk:Page_Forms&action=edit&oldid=5974044 for example, or https://www.mediawiki.org/w/index.php?title=Extension_talk:Page_Forms&veaction=edit&oldid=5974044 with VisualEditor enabled).

Benefits (why should this be implemented?):
Editors can see diff between the out-of-date revision and the latest version and jump to the latest version conveniently (though there're already links in revision-nav, they are unclickable in VisualEditor).

Before:

Screenshot 2023-06-14 at 8.46.42 AM.png (792×2 px, 223 KB)

After:

Screenshot 2023-06-14 at 8.45.55 AM.png (798×2 px, 253 KB)

Details

SubjectRepoBranchLines +/-
Add 'view diff from the latest' & 'edit the latest revision' links to editingold messagemediawiki/coremaster+12 -3
Customize query in gerrit

Event Timeline

Dringsim created this task.Jun 14 2023, 9:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2023, 9:55 AM
Dringsim updated the task description. (Show Details)Jun 14 2023, 9:56 AM
gerritbot added a comment.Jun 14 2023, 9:56 AM

Change 928483 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/core@master] Add 'view diff' & 'edit the latest revision' links to editingold message

https://gerrit.wikimedia.org/r/928483

gerritbot added a project: Patch-For-Review.Jun 14 2023, 9:56 AM
Jdlrobson added a project: Editing-team.Jun 14 2023, 3:46 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: • ppelberg, Jdlrobson.

@ppelberg what do you think about this feature request? We have a patch from a volunteer but I don't want to merge without someone from your team approving it!

Esanders subscribed.EditedJun 14 2023, 4:02 PM

Warning: You are editing an out-of-date revision of this page (view diff). If you publish it, any changes made since this revision will be lost. Edit the latest revision

I'm not sure it's clear what "view diff" means in this context? The diff generated by the edit leading to this revision? The diff between this revision and the latest?

Dringsim added a comment.Jul 8 2023, 6:17 AM
在T339097#8932206中，@Esanders写道：

Warning: You are editing an out-of-date revision of this page (view diff). If you publish it, any changes made since this revision will be lost. Edit the latest revision

I'm not sure it's clear what "view diff" means in this context? The diff generated by the edit leading to this revision? The diff between this revision and the latest?

Use 'view diff from the latest'?

PatchDemoBot added a comment.Jul 31 2023, 12:49 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/25f63d5ea9/w

Pppery edited projects, added MediaWiki-Page-editing; removed MediaWiki-General.Mar 17 2024, 4:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL