Page MenuHomePhabricator
Create Task
Maniphest T339973

WikiEditor shouldn't show help section for references if the Cite extension isn't installed
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • On a development wiki, install and enable Extension:WikiEditor, while keeping Extension:Cite uninstalled/disabled
  • Edit in wikitext mode, click "Help"

What happens:

  • The help thing has a section on references, but if you try to use any of those examples, they won't work.

What should happen:

  • That section should only be visible if the Cite extension is also enabled.

Details

SubjectRepoBranchLines +/-
Move Cite-specific settings from WikiEditormediawiki/extensions/Citemaster+269 -36
Remove (revert) expensive parsing of 1-character messagemediawiki/extensions/Citemaster+29 -31
[Cite & WikiEditor] Change optional messagestranslatewikimaster+5 -2
Move reference-specific settings to the Cite extensionmediawiki/extensions/WikiEditormaster+2 -138
Customize query in gerrit

Event Timeline

jhsoby created this task.Jun 20 2023, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2023, 9:51 PM
gerritbot added a comment.Jun 20 2023, 10:34 PM

Change 931697 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/WikiEditor@master] Remove help section on references if Cite extension not enabled

https://gerrit.wikimedia.org/r/931697

gerritbot added a project: Patch-For-Review.Jun 20 2023, 10:34 PM
Samwilson added a project: Cite.Jun 21 2023, 6:03 AM
Samwilson subscribed.

The reference-insert button is also added by WikiEditor, which seems a bit strange. Cite should add that, and the help text.

gerritbot added a comment.Jun 21 2023, 2:41 PM

Change 931946 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Cite@master] Move Cite-specific settings from WikiEditor

https://gerrit.wikimedia.org/r/931946

gerritbot added a comment.Jun 22 2023, 8:00 AM

Change 932170 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[translatewiki@master] [Cite & WikiEditor] Change optional messages

https://gerrit.wikimedia.org/r/932170

matmarex subscribed.Jun 27 2023, 7:59 PM
gerritbot added a comment.Jun 28 2023, 11:42 PM

Change 931946 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move Cite-specific settings from WikiEditor

https://gerrit.wikimedia.org/r/931946

gerritbot added a comment.Jun 28 2023, 11:43 PM

Change 931697 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Move reference-specific settings to the Cite extension

https://gerrit.wikimedia.org/r/931697

matmarex closed this task as Resolved.Jun 29 2023, 12:18 AM
matmarex assigned this task to jhsoby.

Thanks for the patches!

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 29 2023, 1:00 AM
gerritbot added a comment.Jun 29 2023, 8:27 AM

Change 932170 merged by jenkins-bot:

[translatewiki@master] [Cite & WikiEditor] Change optional messages

https://gerrit.wikimedia.org/r/932170

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 8:30 AM
jhsoby added a comment.Jun 29 2023, 10:42 PM

And thanks for the review, @matmarex! :-)

gerritbot added a comment.Jul 21 2023, 12:05 PM

Change 940343 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove (revert) expensive parsing of 1-character message

https://gerrit.wikimedia.org/r/940343

gerritbot added a project: Patch-For-Review.Jul 21 2023, 12:05 PM
gerritbot added a comment.Jul 25 2023, 8:29 PM

Change 940343 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove (revert) expensive parsing of 1-character message

https://gerrit.wikimedia.org/r/940343

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 8:30 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 25 2023, 9:00 PM
happy5214 moved this task from Backlog to Closed on the WikiEditor (2010) board.Jul 31 2023, 10:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL