Page MenuHomePhabricator

Mark as resolved is not persisted within the current session
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

"Mark as resolved" option allows to tell Content translation that the user has reviewed the issue, and this is considered to make the translation limits less strict as documented in this page. Recently a regression is making the application of the "Mark as resolved" option to be forgotten as the limits are re-evaluated when the user moves to the next paragraph.

Support for persisting this option across session is part of a different ticket (T202544). The current one is focused on the support within the same translation session which used to work but now does not.

Steps to replicate the issue:

  • try to translate any page from english to dutch
  • get a paragraph to your choice of 98%, 95% or 87%
  • mark as resolved
  • notice the yellow dissappearing
  • edit elsewhere
  • warning re-appears immediately

What happens?:
Warnings can not be suppressed.

What should have happened instead?:
Warning is suppressed until user tries to publish the page, which then re-activates all warnings.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Firefox, Fedora.

p.s.
This has to be a duplicate of a different ticket, someone must have complained before, but i couldn't find it.

Event Timeline

Pginer-WMF renamed this task from CX2: Mark as resolved does not work to Mark as resolved is not persisted within the current session.Jul 4 2023, 1:01 PM
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF subscribed.

This seems a regression. Probably after the recent changes about the way warnings are evaluated and communicated to users (T285861, T263116). Added some additional details to the ticket and connected to relevant tickets as a sub-task of T251887: Review the MT limits system and how it is presented to users
Thanks for reporting!

Pginer-WMF triaged this task as Medium priority.Jul 4 2023, 1:08 PM

no problem, I am having a hard time using phabricator rn.
knowing I made at least 1 useful ticket is good to know 😅

hueitan set the point value for this task to 3.

Change #1165057 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/ContentTranslation@master] CX: Persist "Mark as resolved" within the current session

https://gerrit.wikimedia.org/r/1165057

hueitan changed the point value for this task from 3 to 2.Jul 1 2025, 12:32 PM

Change #1165057 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Persist "Mark as resolved" within the current session

https://gerrit.wikimedia.org/r/1165057

Nikerabbit subscribed.

What should have happened instead?:
Warning is suppressed until user tries to publish the page, which then re-activates all warnings.

Warning does not reappear after trying to publish.

What should have happened instead?:
Warning is suppressed until user tries to publish the page, which then re-activates all warnings.

Warning does not reappear after trying to publish.

There is the additional rule during the publish for "less strict threshold", therefore user unable to continue the publish https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/503559

Still trying to figure out how to do a screencast, so trying text explanation:

  • start translation of any page
  • fill a paragraph with machine translation
  • get a "high MT" warning fr the paragraph
  • mark it as resolved
  • try to publish
  • get a publish failure due to high MT

Observation: Warning for the paragraph is not shown
Inferred expectation: Warning for the paragraph is shown again to make it more clear which paragraphs need more edits

@Pginer-WMF @SGautam_WMF thoughts?

I can confirm that, the "less strict" unmodified error appear when trying to publish

above strict thresholdabove strict threshold

"less strict threshold", from T217653: CX2: Improve the approach used for adding translations to the "unreviewed content" tracking category

Consider a less strict threshold for paragraphs that users marked as resolved. For paragraphs where the unmodified content warning was shown but the user marked it as resolved, we can apply a less strict threshold (95% of Machine translation or 75% of source content). This will provide a way to accommodate cases where the automatic translation was exceptionally good, but still avoid potential abuse of the feature (i.e., not following blindly the user confirmation).


The interface missing the information that telling the user they are in the less strict threshold. It just show the same error when user edit it.

Nikerabbit changed the task status from Open to Stalled.Jul 16 2025, 7:23 AM

Still trying to figure out how to do a screencast, so trying text explanation:

  • start translation of any page
  • fill a paragraph with machine translation
  • get a "high MT" warning fr the paragraph
  • mark it as resolved
  • try to publish
  • get a publish failure due to high MT

Observation: Warning for the paragraph is not shown
Inferred expectation: Warning for the paragraph is shown again to make it more clear which paragraphs need more edits

@Pginer-WMF @SGautam_WMF thoughts?

Agreed with Inferred expectation here, created following task to address that - T399798

Nikerabbit moved this task from In Progress to Done on the LPL Essential (2025 Jul-Oct) board.

Thanks. I'll consider this task resolved then.