Page MenuHomePhabricator

Empty warning box on Special:Translate
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to Special:Translate

What happens?:
You'll see an empty warning box appear at the top.

image.png (399×1 px, 56 KB)

What should have happened instead?:
Should not see an empty warning box

Software version (skip for WMF-hosted wikis like Wikipedia):
MediaWiki: master
Translate: master

Other information (browser name/version, screenshots, etc.):
Firefox 114.0.1 on Linux

Started happening once https://gerrit.wikimedia.org/r/c/mediawiki/core/+/893061 landed.
Translate extension uses the following CSS to hide or show the warning box:

.tux-group-warning:empty {
  display: none
}

With https://gerrit.wikimedia.org/r/c/mediawiki/core/+/893061, it is no longer empty and has the following elements:

<span class="cdx-message__icon"></span><div class="cdx-message__content"></div>

Event Timeline

Change 932049 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Empty the tux group warning container if there are no warnings

https://gerrit.wikimedia.org/r/932049

Change 932164 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Do not add empty tux group warning container on server side

https://gerrit.wikimedia.org/r/932164

abi_ set the point value for this task to 1.

Change 932049 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] Empty the tux group warning container if there are no warnings

Reason:

In favor of Ib090b26841b2f175c7825768aec17a3d4b5300e4

https://gerrit.wikimedia.org/r/932049

Change 932164 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Do not add empty tux group warning container on server side

https://gerrit.wikimedia.org/r/932164

This is fixed and tested on translatewiki.net