Page MenuHomePhabricator
Create Task
Maniphest T340065

Migrate Database::delete usages to DeleteQueryBuilder
Open, Needs TriagePublic
Actions

Description

Similar to T311866: Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions) and T330640: Migrate Database::update usages to UpdateQueryBuilder

Details

SubjectRepoBranchLines +/-
tests: Migrate Database::delete calls to DeleteQueryBuildermediawiki/coremaster+30 -15
site: Use DeleteQueryBuilder in DBSiteStoremediawiki/coremaster+11 -8
Migrate most calls of Database::delete to DeleteQueryBuildermediawiki/coremaster+210 -147
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Jun 21 2023, 8:53 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJun 21 2023, 8:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 21 2023, 8:58 PM

Change 932005 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Migrate most calls of Database::delete to DeleteQueryBuilder

https://gerrit.wikimedia.org/r/932005

gerritbot added a project: Patch-For-Review.Jun 21 2023, 8:58 PM
gerritbot added a comment.Jun 27 2023, 9:00 AM

Change 932005 abandoned by Ladsgroup:

[mediawiki/core@master] Migrate most calls of Database::delete to DeleteQueryBuilder

Reason:

Done in Ie0c1c955ca1a7

https://gerrit.wikimedia.org/r/932005

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2023, 9:10 AM
gerritbot added a comment.Jul 6 2023, 10:04 PM

Change 936094 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] site: Use DeleteQueryBuilder in DBSiteStore

https://gerrit.wikimedia.org/r/936094

gerritbot added a project: Patch-For-Review.Jul 6 2023, 10:04 PM
gerritbot added a comment.Jul 7 2023, 11:16 AM

Change 936094 merged by jenkins-bot:

[mediawiki/core@master] site: Use DeleteQueryBuilder in DBSiteStore

https://gerrit.wikimedia.org/r/936094

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2023, 11:30 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 7 2023, 1:00 PM
Krinkle edited projects, added MediaWiki-General; removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), MediaWiki-libs-Rdbms, Performance-Team.Jul 11 2023, 1:08 AM
gerritbot added a comment.Jul 14 2023, 12:49 PM

Change 938236 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] tests: Migrate Database::delete calls to DeleteQueryBuilder

https://gerrit.wikimedia.org/r/938236

gerritbot added a project: Patch-For-Review.Jul 14 2023, 12:49 PM
gerritbot added a comment.Jul 14 2023, 1:23 PM

Change 938236 merged by jenkins-bot:

[mediawiki/core@master] tests: Migrate Database::delete calls to DeleteQueryBuilder

https://gerrit.wikimedia.org/r/938236

Maintenance_bot removed a project: Patch-For-Review.Jul 14 2023, 1:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 14 2023, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits