Page MenuHomePhabricator
Create Task
Maniphest T340112

PageTriage: Add example jest smoke test for curation toolbar
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In T339831#8946898, I mentioned that we could avoid breakage by adding smoke tests for the components mentioned in T320924: Add end-to-end browser tests to PageTriage (keyword: selenium)
To quote the curation toolbar section:

  • should be minimizable, closeable, and openable (first button)
  • should open information sub-menu (second button)
  • should open wikilove sub-menu, and send wikilove (third button) (extra setup: installation of WikiLove extension)
  • should open mark as reviewed sub-menu, mark as reviewed, and mark as unreviewed (fourth button)
  • should send a message to the creator (fourth button)
  • should open maintenance tag sub-menu, and apply {{More footnotes}} (fifth button) (extra setup: MediaWiki:PageTriageExternalTagsOptions.js)
  • should open deletion tag sub-menu, and apply a CSD G11 (Unambiguous advertising or promotion) tag (sixth button) (extra setup:
  • should open deletion tag sub-menu, and apply a prod tag (sixth button) (extra setup: MediaWiki:PageTriageExternalDeletionTagsOptions.js)
  • should open deletion tag sub-menu, and apply an AFD tag (sixth button) (extra setup: MediaWiki:PageTriageExternalDeletionTagsOptions.js)
  • should proceed to next unreviewed article in queue (seventh button)

Details

SubjectRepoBranchLines +/-
Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loadedmediawiki/extensions/PageTriagemaster+16 -13
Add some jest coverage for recent regressionsmediawiki/extensions/PageTriagemaster+140 -9
Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loadedmediawiki/extensions/PageTriagewmf/1.41.0-wmf.17+16 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

jsn.sherman created this task.Jun 22 2023, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2023, 1:22 PM
jsn.sherman added a parent task: T334506: Improve Javascript testing coverage in PageTriage.Jun 22 2023, 1:23 PM
jsn.sherman renamed this task from PageTriage: Add jest smoke tests for curation toolbar to PageTriage: Add example jest smoke test for curation toolbar.Jun 22 2023, 3:02 PM
• Samwalton9-WMF triaged this task as Medium priority.Jun 22 2023, 3:43 PM
• Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
• Samwalton9-WMF set the point value for this task to 3.
Novem_Linguae awarded a token.Jun 22 2023, 8:40 PM
Novem_Linguae mentioned this in T339831: CurationToolbar gives "mw.pageTriage.contentLanguageMessage is not a function" error when trying to add a speedy deletion tag.Jul 2 2023, 12:16 AM
gerritbot added a comment.Jul 7 2023, 8:55 PM

Change 936330 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] Add some jest coverage for recent regressions

https://gerrit.wikimedia.org/r/936330

gerritbot added a project: Patch-For-Review.Jul 7 2023, 8:55 PM
gerritbot added a comment.Jul 10 2023, 11:09 AM

Change 936330 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add some jest coverage for recent regressions

https://gerrit.wikimedia.org/r/936330

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 11:11 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 12:00 PM
gerritbot added a comment.Jul 11 2023, 7:18 PM

Change 937169 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded

https://gerrit.wikimedia.org/r/937169

gerritbot added a project: Patch-For-Review.Jul 11 2023, 7:18 PM
jsn.sherman changed the task status from Open to In Progress.Jul 11 2023, 8:58 PM

It looks like 936330 introduced Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded; we'll want to deal with that before the train rolls out to english wikipedia.

gerritbot added a comment.Jul 12 2023, 5:18 PM

Change 937169 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded

https://gerrit.wikimedia.org/r/937169

TheresNoTime subscribed.Jul 12 2023, 5:26 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 12 2023, 5:31 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 12 2023, 6:00 PM
gerritbot added a comment.Jul 12 2023, 7:41 PM

Change 937478 had a related patch set uploaded (by Samtar; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@wmf/1.41.0-wmf.17] Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded

https://gerrit.wikimedia.org/r/937478

gerritbot added a project: Patch-For-Review.Jul 12 2023, 7:41 PM
gerritbot added a comment.Jul 12 2023, 8:07 PM

Change 937478 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.41.0-wmf.17] Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded

https://gerrit.wikimedia.org/r/937478

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2023, 8:11 PM
Stashbot added a comment.Jul 12 2023, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-12T20:11:49Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:937478|Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded (T340112)]]

Stashbot added a comment.Jul 12 2023, 8:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-12T20:13:23Z] <samtar@deploy1002> samtar: Backport for [[gerrit:937478|Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded (T340112)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Jul 12 2023, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-12T20:21:16Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:937478|Fix Error: Module "./ext.pageTriage.defaultTagsOptions.js" is not loaded (T340112)]] (duration: 09m 27s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 12 2023, 9:00 PM
jsn.sherman moved this task from Ready to Done on the Moderator-Tools-Team (Kanban) board.Jul 12 2023, 9:47 PM

The fix has been backported.

• Samwalton9-WMF closed this task as Resolved.Jul 18 2023, 4:09 PM
• Samwalton9-WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL