Page MenuHomePhabricator

Remove pageviews from newcomer tasks desktop post-edit dialog
Closed, ResolvedPublic

Description

The post-edit dialog shows pageview counts on desktop:

Screen Shot 2023-06-06 at 11.39.56 AM.png (616×1 px, 115 KB)

As detailed in the design specs, post-edit dialogs shouldn't be showing the pageview count due to space constraints (neither on mobile nor desktop).

Frame.png (766×1 px, 101 KB)

This is particularly problematic for section-level image suggestions as the task name is so long that the pageview gets displayed in a confusing way.

(split out from T338286: Section-level image - minor UI usability issues)

Event Timeline

Chatted with Rita about this on Tue, and per the specs, post-edit dialogs shouldn't be showing the pageview count due to space constraints (neither on mobile nor desktop).

Frame.png (766×1 px, 101 KB)

I apologize for the confusion. I pointed @Sgs at the original design specs in T245790 at some point, and he added in the pageviews on desktop based on those (rEGREdd07e3f64873: Post edit panel: show the pageviews in desktop). Apparently the specs changed at some point and I forgot about it.

Change 938962 had a related patch set uploaded (by KMorgan; author: KMorgan):

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: Do not show pageviews

https://gerrit.wikimedia.org/r/938962

Change 938345 had a related patch set uploaded (by KMorgan; author: KMorgan):

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: Do not show pageviews

https://gerrit.wikimedia.org/r/938345

Change 938962 abandoned by KMorgan:

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: Do not show pageviews

Reason:

Messed up patch tree

https://gerrit.wikimedia.org/r/938962

Change 938345 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: Do not show pageviews

https://gerrit.wikimedia.org/r/938345