Page MenuHomePhabricator

LibUp bot opening multiple upgrade notices for same lib
Open, Needs TriagePublic

Description

LibUp both has been being extra helpful with OpenRefine in PAWS

T340932 T340916 T340894 T340794 T340698 T340594 have all been opened for OpenRefine 3.7.3. Though this was completed early on in T340698:

https://github.com/toolforge/paws/blob/af131628e6b69d63f040889b3acfb9ca02e2d511/images/singleuser/Dockerfile#L170

One ticket is just the right number, could we get it to do that again?

Event Timeline

Jul 03 22:18:45 upgrader-06 libup-run[21259]: Traceback (most recent call last):
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/bin/libup-run", line 33, in <module>
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     sys.exit(load_entry_point('libup', 'console_scripts', 'libup-run')())
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/libup/run.py", line 134, in main
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     update_monitoring(session)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/libup/run.py", line 107, in update_monitoring
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     projects=info['phab']
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/libup/phab.py", line 40, in create_task
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     result = phab.maniphest.createtask(title=title, description=desc, projectPHIDs=phids)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/phabricator/__init__.py", line 253, in __call__
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     return self._request(**kwargs)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/phabricator/__init__.py", line 307, in _request
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     response = requests.post(path, data=body, headers=headers, timeout=self.api.timeout)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/requests/api.py", line 117, in post
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     return request('post', url, data=data, json=json, **kwargs)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/requests/api.py", line 61, in request
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     return session.request(method=method, url=url, **kwargs)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/requests/sessions.py", line 529, in request
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     resp = self.send(prep, **send_kwargs)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/requests/sessions.py", line 645, in send
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     r = adapter.send(request, **kwargs)
Jul 03 22:18:45 upgrader-06 libup-run[21259]:   File "/srv/libraryupgrader/venv/lib/python3.7/site-packages/requests/adapters.py", line 532, in send
Jul 03 22:18:45 upgrader-06 libup-run[21259]:     raise ReadTimeout(e, request=request)
Jul 03 22:18:45 upgrader-06 libup-run[21259]: requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='phabricator.wikimedia.org', port=443): Read timed out. (read timeout=5)

Hrmmm

legoktm@upgrader-06:~$ ping phabricator.wikimedia.org
PING phabricator.wikimedia.org (208.80.154.224) 56(84) bytes of data.
^C
--- phabricator.wikimedia.org ping statistics ---
3 packets transmitted, 0 received, 100% packet loss, time 49ms

I want to say this has happened before? Anyways, rebooting it to see if that fixes it...

Didn't help :|

legoktm@upgrader-06:~$ ping phabricator.wikimedia.org
PING phabricator.wikimedia.org (208.80.154.224) 56(84) bytes of data.
^C
--- phabricator.wikimedia.org ping statistics ---
3 packets transmitted, 0 received, 100% packet loss, time 32ms

This is also a pretty old buster VM that I've been meaning to recreate as bullseye bookworm...

The weird thing is that the initial creation request is actually making it through to Phabricator, it just times out reading the response so it doesn't think the task was created and then tries to file another one, and loop...

I've turned off libup until we can get this fixed :/ (not that it was really running regardless)

Maybe it got fixed already, but I'm able to curl to phabricator without issues, so it's either application specific or it's sorted out?

root@upgrader-06:~# curl -v https://phabricator.wikimedia.org >/dev/null
...
< HTTP/2 200 
< date: Tue, 04 Jul 2023 08:27:07 GMT
...

Maybe it got fixed already, but I'm able to curl to phabricator without issues, so it's either application specific or it's sorted out?

I'm not immediately convinced, as T341014 opened just a little before this comment. Unless something besides turning it off occurred in the preceding hour and a half.