Page MenuHomePhabricator

Manually constructing action=delete URLs displays a deletion form instead of an error message
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

A deletion forms appears, despite logged out users not having the delete permission (nor bigdelete, which is needed to actually delete Prague from enwiki):

image.png (1×3 px, 520 KB)

Actually submitting the form gives me an error message both logged out and from an insufficiently privileged account.

What should have happened instead?:

An error message should be shown, along the lines of "You need to be an administrator".

Notes

This issue gave me a mini heart attack for a short while and for a while I thought "OMG, logged out users can delete pages now, what happened". This has also confused at least one administrator who thought "I am not actually supposed to be able to delete big pages" (with more than 5k) revisions. So, this should be fixed even though it apparently isn't connected with a security vulnerability.

Event Timeline

Again, caused by c3e43d31874eb874d4132c2caa68b7258d6b9a0b (T337304). These classes should be carefully reviewed in case they introduced more issues.

Change 935127 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] DeleteAction: Avoid displaying the form unconditionally

https://gerrit.wikimedia.org/r/935127

Change 935127 merged by jenkins-bot:

[mediawiki/core@master] DeleteAction: Avoid displaying the form unconditionally

https://gerrit.wikimedia.org/r/935127

Change 935121 had a related patch set uploaded (by Urbanecm; author: Func):

[mediawiki/core@wmf/1.41.0-wmf.16] DeleteAction: Avoid displaying the form unconditionally

https://gerrit.wikimedia.org/r/935121

Change 935122 had a related patch set uploaded (by Urbanecm; author: Func):

[mediawiki/core@wmf/1.41.0-wmf.15] DeleteAction: Avoid displaying the form unconditionally

https://gerrit.wikimedia.org/r/935122

Change 935121 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.16] DeleteAction: Avoid displaying the form unconditionally

https://gerrit.wikimedia.org/r/935121

Mentioned in SAL (#wikimedia-operations) [2023-07-04T13:35:49Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:935121|DeleteAction: Avoid displaying the form unconditionally (T341002)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-04T13:37:23Z] <lucaswerkmeister-wmde@deploy1002> urbanecm and lucaswerkmeister-wmde: Backport for [[gerrit:935121|DeleteAction: Avoid displaying the form unconditionally (T341002)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-04T13:44:14Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:935121|DeleteAction: Avoid displaying the form unconditionally (T341002)]] (duration: 08m 25s)

Change 935122 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.15] DeleteAction: Avoid displaying the form unconditionally

https://gerrit.wikimedia.org/r/935122

Mentioned in SAL (#wikimedia-operations) [2023-07-04T13:57:35Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:935122|DeleteAction: Avoid displaying the form unconditionally (T341002)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-04T13:59:02Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and urbanecm: Backport for [[gerrit:935122|DeleteAction: Avoid displaying the form unconditionally (T341002)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-04T14:16:16Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:935122|DeleteAction: Avoid displaying the form unconditionally (T341002)]] (duration: 18m 41s)