Page MenuHomePhabricator
Create Task
Maniphest T341630

Inline diff: remove temporary inline switch flag
Closed, ResolvedPublic
Actions

Description

Remove the $wgShowDiffToggleSwitch flag so the the inline switcher is always shown.

Details

SubjectRepoBranchLines +/-
DiffToggleSwitch: remove temporary inline switch flagmediawiki/coremaster+3 -39
DiffToggleSwitch: remove temporary inline switch flagmediawiki/coremaster+21 -48
Customize query in gerrit

Related Objects

Event Timeline

HMonroy created this task.Jul 11 2023, 9:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2023, 9:33 PM
TheresNoTime claimed this task.Jul 12 2023, 1:15 PM
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
TheresNoTime subscribed.

Will put a patch in, but assuming we don't want to merge yet?

gerritbot added a comment.Jul 12 2023, 1:16 PM

Change 937464 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/core@master] DiffToggleSwitch: remove temporary inline switch flag

https://gerrit.wikimedia.org/r/937464

gerritbot added a project: Patch-For-Review.Jul 12 2023, 1:16 PM
TheresNoTime moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Jul 24 2023, 3:47 PM
gerritbot added a comment.Jul 26 2023, 12:40 PM

Change 937464 abandoned by Samtar:

[mediawiki/core@master] DiffToggleSwitch: remove temporary inline switch flag

Reason:

https://gerrit.wikimedia.org/r/937464

gerritbot added a comment.Jul 26 2023, 12:54 PM

Change 941929 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/core@master] DiffToggleSwitch: remove temporary inline switch flag

https://gerrit.wikimedia.org/r/941929

TheresNoTime changed the task status from Open to Stalled.Aug 9 2023, 10:36 AM
HMonroy changed the task status from Stalled to Open.Sep 6 2023, 6:15 PM
HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Sep 6 2023, 8:31 PM
gerritbot added a comment.Sep 6 2023, 8:46 PM

Change 941929 merged by jenkins-bot:

[mediawiki/core@master] DiffToggleSwitch: remove temporary inline switch flag

https://gerrit.wikimedia.org/r/941929

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 6 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 9:10 PM
dom_walden moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Sep 14 2023, 7:45 AM
dom_walden subscribed.

In T341955 I tested the inline toggle on beta and production. It appears to be enabled everywhere (except for content types which are not supported by inline diffs).

dmaza closed this task as Resolved.Sep 15 2023, 9:20 PM
dmaza subscribed.
In T341630#9165666, @dom_walden wrote:

In T341955 I tested the inline toggle on beta and production. It appears to be enabled everywhere (except for content types which are not supported by inline diffs).

This is expected behavior. Thank you. Resolving now

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL