Page MenuHomePhabricator
Create Task
Maniphest T341763

Reenable flakey Selenium tests
Closed, ResolvedPublic
Actions

Description

We are facing issues with testing Popup extension with selenium while all seems to be working fine selenium seems to indicate a failure. We've manually verified the functionality is still working and have skipped the test for now.

We need to:

Details

SubjectRepoBranchLines +/-
Browser tests: Skip another testmediawiki/extensions/Popupsmaster+1 -1
Skip flakey Selenium test for nowmediawiki/extensions/Popupsmaster+2 -1
Customize query in gerrit

Event Timeline

• Mabualruz created this task.Jul 13 2023, 7:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2023, 7:19 AM
gerritbot added a comment.Jul 13 2023, 3:15 PM

Change 937542 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Skip flakey Selenium test for now

https://gerrit.wikimedia.org/r/937542

gerritbot added a project: Patch-For-Review.Jul 13 2023, 3:15 PM
gerritbot added a comment.Jul 13 2023, 3:31 PM

Change 937542 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Skip flakey Selenium test for now

https://gerrit.wikimedia.org/r/937542

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 13 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 4:10 PM
Jdlrobson edited projects, added Reference Previews, Quality-and-Test-Engineering-Team; removed Web-Team-Backlog.Jul 13 2023, 5:05 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from Reenable flakey Selenium test to Reenable flakey Selenium tests.Jul 14 2023, 4:56 PM
Jdlrobson subscribed.

"Dwelling on a valid reference link.Dwelling references links inside reference previews does not close the popup" is now also failing for no obvious reason.

gerritbot added a comment.Jul 14 2023, 4:57 PM

Change 938281 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Browser tests: Skip another test

https://gerrit.wikimedia.org/r/938281

gerritbot added a project: Patch-For-Review.Jul 14 2023, 4:57 PM
gerritbot added a comment.Jul 15 2023, 5:18 PM

Change 938281 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Browser tests: Skip another test

https://gerrit.wikimedia.org/r/938281

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2023, 5:30 PM
zeljkofilipin subscribed.Jul 17 2023, 4:31 PM

@Jdlrobson you have tagged Quality-and-Test-Engineering-Team, do you need our help?

Jdlrobson added a comment.Jul 18 2023, 5:35 PM
In T341763#9020559, @zeljkofilipin wrote:

@Jdlrobson you have tagged Quality-and-Test-Engineering-Team, do you need our help?

Possibly. The test only recently started to fail despite no changes to the extension, so it's possible something is wrong with the daily job. I am not familiar with this code however (it is maintained by WMDE), so cannot confirm.

WMDE-Fisch closed this task as Resolved.May 30 2024, 9:23 AM
WMDE-Fisch subscribed.

Tests have been re-enabled for some time now and seem to be running fine. Feel free to re-open if you think there's some issue that remains.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits