Page MenuHomePhabricator
Create Task
Maniphest T341872

Can not reach revision popups content via keyboard
Closed, ResolvedPublic
Actions

Description

Currently it is not possible to reach the interactive contents of a revision popup by using the keyboard only. Since all interactive elements should be reachable via keyboard, we should change that.

Screenshot from 2023-06-29 14-26-31.png (491×846 px, 73 KB)

Open question: Which key would make sense? Tab or space? --> Check how similar use cases are handled in OOUI.

Implemented as a MVP solution:

  • When the user focuses a pointer, the tooltip is displayed.
  • The Tab key can be used to navigate into a popup and out of it again.

Details

SubjectRepoBranchLines +/-
Don't trigger hover or tooltips from a tooltipmediawiki/extensions/RevisionSlidermaster+3 -3
Append tooltip to focused pointer to allow tabbing into itmediawiki/extensions/RevisionSlidermaster+9 -4
Remove obsolete per-skin CSSmediawiki/extensions/RevisionSlidermaster+0 -22
Restore highlightable-row CSS we accidentally removedmediawiki/extensions/RevisionSlidermaster+11 -9
Trigger popup creation on pointer focusmediawiki/extensions/RevisionSlidermaster+16 -0
Don't re-create tooltip when it's already theremediawiki/extensions/RevisionSlidermaster+10 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

lilients_WMDE created this task.Jul 14 2023, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2023, 1:43 PM
WMDE-Fisch claimed this task.Aug 23 2023, 10:08 AM
WMDE-Fisch moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.
gerritbot added a comment.Aug 23 2023, 10:09 AM

Change 951894 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/RevisionSlider@master] [WIP] Append tooltip to focused pointer to allow tabbing into it

https://gerrit.wikimedia.org/r/951894

gerritbot added a project: Patch-For-Review.Aug 23 2023, 10:09 AM
WMDE-Fisch mentioned this in T341873: Make revision selectable via keyboard.Aug 23 2023, 10:12 AM
gerritbot added a comment.Aug 25 2023, 1:35 PM

Change 952354 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/RevisionSlider@master] Don't re-create tooltip when it's already there

https://gerrit.wikimedia.org/r/952354

gerritbot added a comment.Aug 25 2023, 1:53 PM

Change 952354 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Don't re-create tooltip when it's already there

https://gerrit.wikimedia.org/r/952354

gerritbot added a comment.Aug 25 2023, 2:43 PM

Change 952460 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/RevisionSlider@master] Trigger popup creation on pointer focus

https://gerrit.wikimedia.org/r/952460

gerritbot added a comment.Aug 28 2023, 12:50 PM

Change 951894 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Append tooltip to focused pointer to allow tabbing into it

https://gerrit.wikimedia.org/r/951894

gerritbot added a comment.Aug 28 2023, 12:58 PM

Change 952460 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Trigger popup creation on pointer focus

https://gerrit.wikimedia.org/r/952460

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2023, 1:10 PM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Aug 28 2023, 1:18 PM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Doing to Done on the WMDE-TechWish-Maintenance-2023 board.
WMDE-Fisch subscribed.
awight closed this task as Resolved.Aug 29 2023, 8:11 AM
gerritbot added a comment.Aug 29 2023, 3:26 PM

Change 953292 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Restore highlightable-row CSS we accidentally removed

https://gerrit.wikimedia.org/r/953292

gerritbot added a project: Patch-For-Review.Aug 29 2023, 3:26 PM
gerritbot added a comment.Aug 29 2023, 3:30 PM

Change 953293 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Remove obsolete per-skin CSS

https://gerrit.wikimedia.org/r/953293

gerritbot added a comment.Aug 29 2023, 3:46 PM

Change 953292 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Restore highlightable-row CSS we accidentally removed

https://gerrit.wikimedia.org/r/953292

gerritbot added a comment.Aug 29 2023, 3:47 PM

Change 953293 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Remove obsolete per-skin CSS

https://gerrit.wikimedia.org/r/953293

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2023, 4:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 3:01 AM
gerritbot added a comment.Aug 30 2023, 12:40 PM

Change 953602 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/RevisionSlider@master] Don't trigger hover or tooltips from a tooltip

https://gerrit.wikimedia.org/r/953602

gerritbot added a project: Patch-For-Review.Aug 30 2023, 12:40 PM
gerritbot added a comment.Sep 4 2023, 9:35 AM

Change 953602 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Don't trigger hover or tooltips from a tooltip

https://gerrit.wikimedia.org/r/953602

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2023, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits