Page MenuHomePhabricator

Accordion: Remove "disabled" property for now
Closed, ResolvedPublic1 Estimated Story Points

Description

Based on the initial accessibility audit of the Accordion component (as part of T341493), including a disabled state for the Accordion leads to some potential accessibility issues without satisfying any known use-cases ("should a disabled accordion component be always open? does that mean we gray out the content text or just the toggle heading?").

Given this, we are going to remove the disabled prop from this component for the time being, since we are about to release it for public usage as part of Codex v0.15.0. This will allow us to proceed with our original plan to take this component out of WIP status so that people can start using it.

We are open to re-introducing this property in the future once we have an actual use-case to work with. If/when this happens, we should be mindful to study the relevant patterns in the W3C's Aria Authoring Practices Guide (APG) – in particular, this one.

Acceptance Criteria

Design

Code

  • Remove the disabled property from the component without otherwise changing its behavior
  • Ensure that the Accordion component made public with the next Codex release

Event Timeline

egardner set the point value for this task to 1.Jul 17 2023, 6:18 PM

Change 938921 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] Accordion: Remove "disabled" property for now

https://gerrit.wikimedia.org/r/938921

Change 938921 merged by jenkins-bot:

[design/codex@main] Accordion: Remove "disabled" property for now

https://gerrit.wikimedia.org/r/938921

Change 939386 had a related patch set uploaded (by Jforrester; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v0.14.0 to v0.15.0

https://gerrit.wikimedia.org/r/939386

Change 939386 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.14.0 to v0.15.0

https://gerrit.wikimedia.org/r/939386