Maniphest T342351

Postgres installation at times reports ERROR: syntax error at or near "pg_advisory_unlock_all" at character 1
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	TheDJ
	Jul 20 2023, 2:30 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

MediaWiki 1.39.4
Postgres

What happens?:
ERROR: syntax error at or near "pg_advisory_unlock_all" at character 1 is reported at times

According to the reporting user this is because in includes/libs/rdbms/database/DatabasePostgres.php in the function doFlushSession, the Query is incorrectly constructed. The effective query should be SELECT pg_advisory_unlock_all() but now it is pg_advisory_unlock_all()

If so, then this problem was introduced in 1.39 by @aaron in Change-ID I60532f86e629c83b357d4832d1963eca17752944

Details

	Subject	Repo	Branch	Lines +/-
	rdbms: Fix postgres db function call	mediawiki/core	REL1_40	+1 -1
	rdbms: Fix postgres db function call	mediawiki/core	REL1_39	+1 -1
	rdbms: Fix postgres db function call	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

TheDJ created this task.Jul 20 2023, 2:30 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptJul 20 2023, 2:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

When fixed, this should probably be back ported to 1.39 being an LTS.

Change 940944 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] rdbms: Fix postgres db function call

https://gerrit.wikimedia.org/r/940944

gerritbot added a project: Patch-For-Review.Jul 24 2023, 1:16 PM

Change 940944 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Fix postgres db function call

https://gerrit.wikimedia.org/r/940944

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 9:10 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 25 2023, 11:01 AM

Change 941406 had a related patch set uploaded (by TheDJ; author: Ammarpad):

[mediawiki/core@REL1_40] rdbms: Fix postgres db function call

https://gerrit.wikimedia.org/r/941406

Change 941407 had a related patch set uploaded (by TheDJ; author: Ammarpad):

[mediawiki/core@REL1_39] rdbms: Fix postgres db function call

https://gerrit.wikimedia.org/r/941407

Change 941407 merged by jenkins-bot:

[mediawiki/core@REL1_39] rdbms: Fix postgres db function call

https://gerrit.wikimedia.org/r/941407

Change 941406 merged by jenkins-bot:

[mediawiki/core@REL1_40] rdbms: Fix postgres db function call

https://gerrit.wikimedia.org/r/941406

ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.40-notes.Jul 26 2023, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2023, 12:10 PM

TheDJ closed this task as Resolved.Jul 26 2023, 6:03 PM

TheDJ assigned this task to Ammarpad.