Maniphest T342479

Wrong uniqueness constraint on ce_question_aggregation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Jul 21 2023, 11:34 PM

Tags

Referenced Files

None

Subscribers

Description

The table has

UNIQUE INDEX ceqag_event_question ( ceqag_event_id, ceqag_question_id ),

but the index should also include ceqag_answer_option. For each event and each question, there can be multiple rows (<=1 for each option).

Update index definition in the code
Schema change in beta
Schema change in production (T342966)

Details

	Subject	Repo	Branch	Lines +/-
	Fix uniqueness constraint for ce_question_aggregation	mediawiki/extensions/CampaignEvents	master	+11 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Daimona	T342479 Wrong uniqueness constraint on ce_question_aggregation
		Resolved		Ladsgroup	T342966 Drop campaign_events.event_answers_status and update ce_question_aggregation's unique index

Event Timeline

Daimona created this task.Jul 21 2023, 11:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2023, 11:34 PM

Daimona moved this task from Needs Input / Design in progress to Ready for development on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 21 2023, 11:38 PM

Change 940940 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix uniqueness constraint for ce_question_aggregation

https://gerrit.wikimedia.org/r/940940

gerritbot added a project: Patch-For-Review.Jul 24 2023, 12:36 PM

Daimona claimed this task.Jul 24 2023, 12:47 PM

Daimona updated the task description. (Show Details)

Daimona moved this task from Ready for development to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

Change 940940 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix uniqueness constraint for ce_question_aggregation

https://gerrit.wikimedia.org/r/940940

Mentioned in SAL (#wikimedia-releng) [2023-07-24T22:44:14Z] <Daimona> Changing index on the ce_question_aggregation DB table in beta wikishared # T342479

Daimona updated the task description. (Show Details)Jul 24 2023, 10:47 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 24 2023, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 11:10 PM

Daimona mentioned this in T342966: Drop campaign_events.event_answers_status and update ce_question_aggregation's unique index.Jul 28 2023, 12:02 PM

Daimona updated the task description. (Show Details)

Daimona moved this task from Code Review to Blocked ⛔ on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

Daimona added a subtask: T342966: Drop campaign_events.event_answers_status and update ce_question_aggregation's unique index.Jul 28 2023, 8:34 PM

Ladsgroup closed subtask T342966: Drop campaign_events.event_answers_status and update ce_question_aggregation's unique index as Resolved.Aug 8 2023, 2:17 PM

Daimona closed this task as Resolved.Aug 8 2023, 3:02 PM

Daimona updated the task description. (Show Details)

Daimona moved this task from Blocked ⛔ to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.