Page MenuHomePhabricator

RSS: Cargo should work with MW 1.35+ but this export format only works with 1.38+
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Do a basic query using MW 1.35.
  • Click "View RSS feed" link.

What happens?:

  • 500 error.

What should have happened instead?:

  • RSS feed displayed.

Software version (skip for WMF-hosted wikis like Wikipedia): MW 1.35, Cargo 3.4.3 (dfbb55a).

Other information (browser name/version, screenshots, etc.):

It breaks at this line:

https://github.com/wikimedia/mediawiki-extensions-Cargo/blob/master/includes/formats/CargoFeedFormat.php#L99

$contentRenderer = MediaWikiServices::getInstance()->getContentRenderer();

See:

Related Objects

Event Timeline

@Samwilson I've added you as a subscriber but don't know whether you get notified automatically by the system...

@Samwilson I've added you as a subscriber but don't know whether you get notified automatically by the system...

Thanks, that's good. I used to watch Cargo, but don't now because I was subscribed to too many things in Phabricator!

I'll make a patch for this for backwards compatibility.

Change 955922 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Cargo@master] Make feed format backwards compatible to MW 1.35

https://gerrit.wikimedia.org/r/955922

Change 955922 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Make feed format backwards compatible to MW 1.35

https://gerrit.wikimedia.org/r/955922

@Jonathan3 Can you test with Cargo's current master and confirm that this is okay now?

Yes, it seems to work all right now! Thanks.