Page MenuHomePhabricator

Serialize ParserOutput::$mWarningMsg
Closed, ResolvedPublic

Description

In T293515 we added ParserOutput::addWarningMsg() to replace ParserOutput::addWarning() -- but we didn't add code to serialize this to the cache.

As such we can't yet use this information in postprocessing or other pipelines which could be retrieving fragments from the cache.

Once this is cached, ParserOutput::getWarnings() should generate the message text on the fly from the cached arguments, which will also help ensure that we don't split the cache on language.

Event Timeline

Change 942714 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate the use of nonserializable arguments to ParserOutput::addWarningMsg()

https://gerrit.wikimedia.org/r/942714

Change 942714 merged by jenkins-bot:

[mediawiki/core@master] Deprecate the use of nonserializable arguments to ParserOutput::addWarningMsg()

https://gerrit.wikimedia.org/r/942714

Change #1149764 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Add ParserOutput::getWarningMsgs(), deprecate ParserOutput::getWarnings()

https://gerrit.wikimedia.org/r/1149764

Change #1149764 merged by jenkins-bot:

[mediawiki/core@master] Add ParserOutput::getWarningMsgs(), deprecate ParserOutput::getWarnings()

https://gerrit.wikimedia.org/r/1149764

matmarex assigned this task to cscott.
matmarex subscribed.

Change #1160244 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Add missing ParserOutput serialization testcases

https://gerrit.wikimedia.org/r/1160244

Change #1160244 merged by jenkins-bot:

[mediawiki/core@master] Add missing ParserOutput serialization testcases

https://gerrit.wikimedia.org/r/1160244