Variant menu's text in Vector 2022 is misaligned with other tabs when page language is set to Chinese
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Diskdance
	Jul 31 2023, 8:47 AM

Description

Looks like another regression. This problem didn't exist several months ago. Probably related to attempts to fix T315219?

Steps to replicate the issue (include links if applicable):

Visit https://zh.wikipedia.beta.wmflabs.org/wiki/%E9%A6%96%E9%A1%B5?safemode=1&uselang=zh-cn&variant=zh-cn

What happens?:
It is misaligned.

What should have happened instead?:
It should not. (screenshots from Wayback Machine)

Other information (browser name/version, screenshots, etc.):
If this issue is caused by attempts to fix T315219 they probably should be reverted because they cause more serious regressions.

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Reset line height on tab elements"	mediawiki/skins/Vector	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: T315219: Chinese sites [Regression] Baseline of the text in the Variant menu in Vector 2022 is misaligned with other tabs when 2 different languages are mixed
Mentioned Here: T315219: Chinese sites [Regression] Baseline of the text in the Variant menu in Vector 2022 is misaligned with other tabs when 2 different languages are mixed

Event Timeline

Diskdance created this task.Jul 31 2023, 8:47 AM

Restricted Application added a project: Internet-Archive. · View Herald TranscriptJul 31 2023, 8:47 AM

Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript

Diskdance renamed this task from Variant menu's text is misaligned regardless of page language to Variant menu's text is misaligned when page language is set to Chinese.Jul 31 2023, 8:48 AM

Diskdance renamed this task from Variant menu's text is misaligned when page language is set to Chinese to Variant menu's text in Vector 2022 is misaligned with other tabs when page language is set to Chinese.

Change 943594 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Revert "Reset line height on tab elements"

https://gerrit.wikimedia.org/r/943594

gerritbot added a project: Patch-For-Review.Aug 1 2023, 12:35 AM

Jdlrobson triaged this task as Low priority.Aug 1 2023, 12:42 AM

Jdlrobson set the point value for this task to 0.

Jdlrobson added a project: Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3).

Jdlrobson moved this task from Incoming to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3) board.

Jdlrobson assigned this task to Edtadros.Aug 1 2023, 12:43 AM

Jdlrobson mentioned this in T315219: Chinese sites [Regression] Baseline of the text in the Variant menu in Vector 2022 is misaligned with other tabs when 2 different languages are mixed.Aug 1 2023, 12:43 AM

Change 943594 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert "Reset line height on tab elements"