Page MenuHomePhabricator
Create Task
Maniphest T343118

EntitySchema editor should have a license note
Closed, ResolvedPublic
Actions

Description

As an editor I want to be informed about the license of contributions I am making to EntitySchemas.

Problem:
We currently don't show a "license of contributions" message when EntitySchema text is edited like we do when an EntitySchema is created (e.g. https://www.wikidata.org/w/index.php?title=EntitySchema:E123&action=edit).

We need to have the same message appear when EntitySchema text is edited to notify the users.

Copy
By clicking "Publish changes", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.

BDD
GIVEN an EntitySchema
AND "license of the contributions" message
WHEN an EntitySchema text is edited
THEN the "license of contributions" message is displayed

Acceptance criteria:

  • "license of contributions" message is displayed on EntitySchemas when an edit of EntitySchema text is made

Details

SubjectRepoBranchLines +/-
Use correct button label in copyright noticemediawiki/extensions/EntitySchemamaster+1 -1
Show copyright notice and anon-user warning when editing schema textmediawiki/extensions/EntitySchemamaster+45 -4
Customize query in gerrit

Event Timeline

Lydia_Pintscher created this task.Jul 31 2023, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2023, 11:53 AM
Lydia_Pintscher triaged this task as High priority.Jul 31 2023, 11:53 AM
Lydia_Pintscher added a project: Wikidata Dev Team.
Michael subscribed.Jul 31 2023, 12:08 PM
Arian_Bozorg updated the task description. (Show Details)Aug 1 2023, 2:33 PM
Arian_Bozorg updated the task description. (Show Details)Aug 2 2023, 8:54 AM
Arian_Bozorg moved this task from Incoming to Unified DOT Backlog on the Wikidata Dev Team board.Aug 2 2023, 9:47 AM
gerritbot added a comment.Aug 2 2023, 2:22 PM

Change 944884 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Show copyright notice and anon-user warning when editing schema text

https://gerrit.wikimedia.org/r/944884

gerritbot added a project: Patch-For-Review.Aug 2 2023, 2:22 PM
Michael moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.Aug 2 2023, 2:23 PM
Michael edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Michael moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Aug 2 2023, 4:21 PM

Change 944884 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Show copyright notice and anon-user warning when editing schema text

https://gerrit.wikimedia.org/r/944884

Michael moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Aug 2 2023, 4:31 PM

You can see the new license note on beta: https://wikidata.beta.wmflabs.org/w/index.php?title=EntitySchema:E1&action=edit

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2023, 4:32 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 2 2023, 5:00 PM
Arian_Bozorg added a comment.Aug 10 2023, 9:44 AM

Thanks so much Michael :)

Could you please update the copy from "Create" to "Publish changes" so that it matches the button?

image.png (499×1 px, 62 KB)

It should read:
By clicking "Publish changes", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.

Arian_Bozorg moved this task from Product Verification to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 10 2023, 9:47 AM
Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.Aug 10 2023, 9:52 AM
In T343118#9082915, @Arian_Bozorg wrote:

Thanks so much Michael :)

Could you please update the copy from "Create" to "Publish changes" so that it matches the button?

image.png (499×1 px, 62 KB)

It should read:
By clicking "Publish changes", you agree to the terms of use, and you irrevocably agree to release your contribution under the Creative Commons CC0 License.

You're completely correct, thank you for catching that! I'll upload a fix right away.

gerritbot added a comment.Aug 10 2023, 9:53 AM

Change 947795 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Use correct button label in copyright notice

https://gerrit.wikimedia.org/r/947795

gerritbot added a project: Patch-For-Review.Aug 10 2023, 9:53 AM
Michael moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Aug 10 2023, 9:55 AM
gerritbot added a comment.Aug 10 2023, 10:46 AM

Change 947795 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Use correct button label in copyright notice

https://gerrit.wikimedia.org/r/947795

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2023, 11:10 AM
Michael moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Aug 10 2023, 12:12 PM

Now the updated message is available on beta: https://wikidata.beta.wmflabs.org/w/index.php?title=EntitySchema:E1&action=edit

Arian_Bozorg closed this task as Resolved.Aug 10 2023, 12:59 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.

Thanks so much!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL