PHP Notice: Undefined index: origin
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Aug 1 2023, 3:59 PM

Description

Error

mwversion: 1.41.0-wmf.19
reqId: ae2373ea-4a67-4754-9da1-385556fd2bc5
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined index: origin

exception.trace

from /srv/mediawiki/php-1.41.0-wmf.19/extensions/ContentTranslation/includes/Store/TranslationCorporaStore.php(230)
#0 /srv/mediawiki/php-1.41.0-wmf.19/extensions/ContentTranslation/includes/Store/TranslationCorporaStore.php(230): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.41.0-wmf.19/extensions/ContentTranslation/includes/ActionApi/ApiContentTranslationSave.php(114): ContentTranslation\Store\TranslationCorporaStore->createTranslationUnitsFromContent(string, integer)
#2 /srv/mediawiki/php-1.41.0-wmf.19/includes/api/ApiMain.php(1915): ContentTranslation\ActionApi\ApiContentTranslationSave->execute()
#3 /srv/mediawiki/php-1.41.0-wmf.19/includes/api/ApiMain.php(892): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.41.0-wmf.19/includes/api/ApiMain.php(863): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.41.0-wmf.19/api.php(95): ApiMain->execute()
#6 /srv/mediawiki/php-1.41.0-wmf.19/api.php(48): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Impact

Notes

The affected function was written in change 784087 last year, as part of T305691.

Since this is a POST request, the parameters are not visible in the URL logged in Logstash, so I used ack to search for the request ID on mwlog1002.eqiad.wmnet:/srv/mw-log/api.log and found the following. The * wildcards were places by me to personal and parameter values.

krinkle@mwlog1002:/srv/mw-log$ ack 'ae2373ea-4a67-4754-9da1-385556fd2bc5' api.log 

2023-08-01 15:26:52.934320 [ae2373ea-4a67-4754-9da1-385556fd2bc5] mw1398 bnwiki 1.41.0-wmf.19 api INFO: API POST * * T=28ms action=cxsave format=json assert=user from=en to=bn sourcetitle=Barkha%20Dutt title=* content=rawdeflate,[...] sourcerevision=1166745622 progress=* cxversion=2 token=[redacted]

Details

Request URL: https://bn.wikipedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	Improve validation in TranslationCorporaStore	mediawiki/extensions/ContentTranslation	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned Here: T305691: Refactor ContentTranslation backend codebase to properly use dependency injection

Event Timeline

Krinkle created this task.Aug 1 2023, 3:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2023, 3:59 PM

Krinkle edited projects, added Language-Team; removed KaiOS-Wikipedia-app (Language).Aug 1 2023, 3:59 PM

Only seeing one instance of this error -> low priority.

Change 946640 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Improve validation in TranslationCorporaStore

https://gerrit.wikimedia.org/r/946640

gerritbot added a project: Patch-For-Review.Aug 8 2023, 12:56 AM

Umherirrender claimed this task.Aug 8 2023, 1:12 AM

Change 946640 merged by jenkins-bot: