Page MenuHomePhabricator

Date/time formatting crashes for Walloon language when using non-UTC time zone
Closed, ResolvedPublicPRODUCTION ERROR

Description

Steps to reproduce:

  1. Visit Walloon Wikipedia
  2. Set a non-UTC time zone in your preference, for example: new mw.Api().saveOption('timecorrection', '+1')
  3. Visit Special:Version (https://wa.wikipedia.org/wiki/Sipeciås:Modêye)

I noticed this when reviewing some code after T343343.

Error
message
DateTime::__construct(): Failed to parse time string (1690852798) at position 8 (9): Unexpected character
trace
from /srv/mediawiki/php-1.41.0-wmf.20/includes/language/Language.php(2123)
#0 /srv/mediawiki/php-1.41.0-wmf.20/includes/language/Language.php(2123): DateTime->__construct(string)
#1 /srv/mediawiki/php-1.41.0-wmf.20/includes/languages/LanguageWa.php(91): Language->userAdjust(string, string)
#2 [internal function]: LanguageWa->timeanddate(string, boolean)
#3 /srv/mediawiki/php-1.41.0-wmf.20/includes/StubObject/StubObject.php(125): call_user_func_array(array, array)
#4 /srv/mediawiki/php-1.41.0-wmf.20/includes/StubObject/StubObject.php(155): MediaWiki\StubObject\StubObject->_call(string, array)
#5 /srv/mediawiki/php-1.41.0-wmf.20/includes/specials/SpecialVersion.php(514): MediaWiki\StubObject\StubObject->__call(string, array)
#6 /srv/mediawiki/php-1.41.0-wmf.20/includes/specials/SpecialVersion.php(466): SpecialVersion::getVersionLinkedGit()
#7 /srv/mediawiki/php-1.41.0-wmf.20/includes/specials/SpecialVersion.php(378): SpecialVersion::getVersionLinked()
#8 /srv/mediawiki/php-1.41.0-wmf.20/includes/specials/SpecialVersion.php(416): SpecialVersion->getSoftwareInformation()
#9 /srv/mediawiki/php-1.41.0-wmf.20/includes/specials/SpecialVersion.php(227): SpecialVersion->softwareInformation()
#10 /srv/mediawiki/php-1.41.0-wmf.20/includes/specialpage/SpecialPage.php(701): SpecialVersion->execute(NULL)
#11 /srv/mediawiki/php-1.41.0-wmf.20/includes/specialpage/SpecialPageFactory.php(1564): SpecialPage->run(NULL)
#12 /srv/mediawiki/php-1.41.0-wmf.20/includes/MediaWiki.php(344): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#13 /srv/mediawiki/php-1.41.0-wmf.20/includes/MediaWiki.php(948): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.41.0-wmf.20/includes/MediaWiki.php(597): MediaWiki->main()
#15 /srv/mediawiki/php-1.41.0-wmf.20/index.php(50): MediaWiki->run()
#16 /srv/mediawiki/php-1.41.0-wmf.20/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}

Event Timeline

Change 946938 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946938

Change 946938 merged by jenkins-bot:

[mediawiki/core@master] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946938

Change 946649 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):

[mediawiki/core@REL1_40] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946649

Change 946650 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):

[mediawiki/core@REL1_39] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946650

Change 946651 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):

[mediawiki/core@REL1_35] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946651

Change 946651 abandoned by Jforrester:

[mediawiki/core@REL1_35] LanguageWa: Fix double timezone adjustment

Reason:

Language not yet present.

https://gerrit.wikimedia.org/r/946651

Change 946650 merged by jenkins-bot:

[mediawiki/core@REL1_39] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946650

Change 946649 merged by jenkins-bot:

[mediawiki/core@REL1_40] LanguageWa: Fix double timezone adjustment

https://gerrit.wikimedia.org/r/946649