Page MenuHomePhabricator
Create Task
Maniphest T34395

Count only links from existing pages on WantedQueryPages
Closed, DeclinedPublic
Actions

Description

changed queries

The WantedQueryPages (WantedPages, WantedTemplates, WantedCategories and WantedImages) are showing often ghost entries. Purging the entries is possible (bug 16112) but not down regularly on all wikis.

I have modify the queries of that 4 special page to count only existing pages. Than this ghost entries are gone from the special page output.

To reach this, the query has to join a second time to the page table to check the *_from fields of existing in the page table.

All special pages are expensive. I hope, the change makes the special pages not too expensive and they can stay on wmf wikis.

Feel free to modify the patch.

Thanks.

Version: 1.20.x
Severity: normal

Attached:

wantedpagecountexisting.patch6 KBDownload

Details

Reference
bz32395

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:03 AM
• bzimport added a project: MediaWiki-Special-pages.
• bzimport set Reference to bz32395.
• bzimport added a subscriber: Unknown Object (MLST).
Umherirrender created this task.Nov 13 2011, 4:38 PM
Reedy added a comment.Nov 20 2011, 3:06 PM

Minor point (not wrong), but as NS_CATEGORY is known to be a number constant, quoting isn't needed, but you're not adding it, just making it database agnostic

Umherirrender added a comment.Jan 19 2012, 8:11 PM

In my opinion it is better to set up a cron job to fix this (bug 16112 comment 17), because other query pages also affected by the ghost entries, but due to a low count of that, you will not see the ghost entries in the result of Special:MostLinkedPages (for example).

Umherirrender added a comment.Apr 23 2012, 4:49 PM

maintenance script now runs periodically (on wmf), no need for this change, from my point of view.

Feel free to commit the patch, if you think, that it is a good thing, but that can make the queries more expensive.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits