Page MenuHomePhabricator

revalidateLinkRecommendations.php cannot run if link-recommendation is disabled in Community configuration
Closed, ResolvedPublic

Description

revalidateLinkRecommendations.php is used by Growth-Team to revalidate the task pool for Add-Link. Unfortunately, as of now, it doesn't run if link-recommendation is disabled from the server configuration. This makes using the script for fixing issues with Add-Link more difficult (such as, ensuring all tasks meet stricter requirements), as one needs to workaround the script limitation first (I did it for ruwiki by enabling link-recommendation is Community configuration, but disabling its frontend in site configuration).

Checking getDisabledTaskTypes() should be sufficient.

Event Timeline

Change 949509 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] LinkRecommendationUpdater: Load link-recommendation even if disabled

https://gerrit.wikimedia.org/r/949509

Change 949509 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] LinkRecommendationUpdater: Load link-recommendation even if disabled

https://gerrit.wikimedia.org/r/949509

Works fine in production, closing!

Change 950813 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.22] LinkRecommendationUpdater: Load link-recommendation even if disabled

https://gerrit.wikimedia.org/r/950813

Change 950813 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.22] LinkRecommendationUpdater: Load link-recommendation even if disabled

https://gerrit.wikimedia.org/r/950813

Mentioned in SAL (#wikimedia-operations) [2023-08-21T20:21:27Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:951151|Growth: Remove wgWelcomeSurveyEnableWithHomepage (T342353 T344619)]], [[gerrit:950812|revalidateLinkRecommendations: Load scoreLessThan correctly (T316079)]], [[gerrit:950813|LinkRecommendationUpdater: Load link-recommendation even if disabled (T344343)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-21T20:23:01Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:951151|Growth: Remove wgWelcomeSurveyEnableWithHomepage (T342353 T344619)]], [[gerrit:950812|revalidateLinkRecommendations: Load scoreLessThan correctly (T316079)]], [[gerrit:950813|LinkRecommendationUpdater: Load link-recommendation even if disabled (T344343)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwde

Mentioned in SAL (#wikimedia-operations) [2023-08-21T20:32:29Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:951151|Growth: Remove wgWelcomeSurveyEnableWithHomepage (T342353 T344619)]], [[gerrit:950812|revalidateLinkRecommendations: Load scoreLessThan correctly (T316079)]], [[gerrit:950813|LinkRecommendationUpdater: Load link-recommendation even if disabled (T344343)]] (duration: 11m 02s)