Background
The wgWelcomeSurveyEnableWithHomepage configuration value was introduced for English Wikipedia, to ensure Welcome survey only shows to users who will also become a part of the Newcomer Homepage experiment (T284257). This variable was useful back when English Wikipedia was on few percentages of Growth users (for the rest, Welcome survey provided little to none benefits. This has changed, and English Wikipedia now has Growth features enabled for 100% features. This means the variable doesn't bring anything useful to English Wikipedia as of now, and is enabled largely for legacy reasons.
wgWelcomeSurveyEnableWithHomepage works by ignoring Welcome survey experiment settings, and enforcing the default Welcome survey group if the user is selected for the Homepage experiment. This means the changes implemened in T342353 silently didn't take effect on English Wikipedia.
Since we do not plan to experiment with very low percentages for the Newcomer Homepage, I think we can simply remove the support for wgWelcomeSurveyEnableWithHomepage from GrowthExperiments.
Checklist
- Remove wgWelcomeSurveyEnableWithHomepage from operations/mediawiki-config and thus set it to false (the default) everywhere
- If there are no apparent issues, remove support for wgWelcomeSurveyEnableWithHomepage from the extension.