Page MenuHomePhabricator

Checkbox: Remove <Enter> as key for selecting/unselecting
Closed, ResolvedPublic1 Estimated Story Points

Description

Background and goal

As originally outlined in T343219#9099787, we originally assigned (Enter) to trigger selecting/unselecting a Checkbox.
Neither native HTML, nor the Checkbox APG is providing this.

Assuming it's been historically about having (Enter) submitting an HTML(?) form, with the key assigned only to the submit button.
The only key to trigger the checkbox is Space, not (Enter).

Resources

Acceptance criteria

  • Follow native HTML and trigger only by pressing Space, not (Enter)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 950038 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Checkbox: Remove enter keypress handler to trigger click event

https://gerrit.wikimedia.org/r/950038

Change 950038 merged by jenkins-bot:

[design/codex@main] Checkbox: Remove enter keypress handler to trigger click event

https://gerrit.wikimedia.org/r/950038

Change 953351 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.17.0 to v0.18.0

https://gerrit.wikimedia.org/r/953351

Change 953351 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.17.0 to v0.18.0

https://gerrit.wikimedia.org/r/953351