Page MenuHomePhabricator

Remove VisualEditorTransitionDefault config and AutodisableVisualEditorPref maint script
Closed, ResolvedPublic

Description

Around 2015, when VisualEditor configuration for enwiki and dewiki was being changed from default-off to default-on, these two features were introduced to ease the transition:

  • VisualEditorTransitionDefault configuration option makes it so that when you enable and then disable the beta feature in preferences, the fact that you opted out is recorded in the 'visualeditor-autodisable' preference, so that when the default changes, your account wouldn't be affected.
  • AutodisableVisualEditorPref maintenance script was used to also set the 'visualeditor-autodisable' preference for all users with edits at the time, so that they wouldn't be affected either.

There are probably some tasks around from that time somewhere, I didn't look too hard.

As far as I know this mechanism wasn't used since then. We haven't used it for any of the later VisualEditor rollouts (https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+log/master/dblists/visualeditor-nondefault.dblist).

It seems unlikely that we'll use it again. Maybe it's time to remove it?

Event Timeline

Change 954732 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Remove 'VisualEditorTransitionDefault' and AutodisableVisualEditorPref.php

https://gerrit.wikimedia.org/r/954732

Change 954732 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove 'VisualEditorTransitionDefault' and AutodisableVisualEditorPref.php

https://gerrit.wikimedia.org/r/954732

matmarex claimed this task.

Change 967973 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Remove unused VisualEditor config settings

https://gerrit.wikimedia.org/r/967973

Change 967973 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused VisualEditor config settings

https://gerrit.wikimedia.org/r/967973

Mentioned in SAL (#wikimedia-operations) [2023-10-24T20:16:35Z] <jdrewniak@deploy2002> Started scap: Backport for [[gerrit:967208|Update comment about EditAttemptStep instruments]], [[gerrit:967394|CentralAuth: Clarify why we don't use second-level domain for some wikis (T257852)]], [[gerrit:967973|Remove unused VisualEditor config settings (T344757 T344759)]], [[gerrit:967995|[noop] Explain more thoroughly how the '-' prefix works]]

Mentioned in SAL (#wikimedia-operations) [2023-10-24T20:17:58Z] <jdrewniak@deploy2002> tgr and matmarex and jdrewniak: Backport for [[gerrit:967208|Update comment about EditAttemptStep instruments]], [[gerrit:967394|CentralAuth: Clarify why we don't use second-level domain for some wikis (T257852)]], [[gerrit:967973|Remove unused VisualEditor config settings (T344757 T344759)]], [[gerrit:967995|[noop] Explain more thoroughly how the '-' prefix works]] synced to the testservers (htt

Mentioned in SAL (#wikimedia-operations) [2023-10-24T20:23:56Z] <jdrewniak@deploy2002> Finished scap: Backport for [[gerrit:967208|Update comment about EditAttemptStep instruments]], [[gerrit:967394|CentralAuth: Clarify why we don't use second-level domain for some wikis (T257852)]], [[gerrit:967973|Remove unused VisualEditor config settings (T344757 T344759)]], [[gerrit:967995|[noop] Explain more thoroughly how the '-' prefix works]] (duration: 07m 21s)