Edit recovery data is loaded on every realtime preview
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Samwilson
	Aug 28 2023, 1:59 AM

Description

Steps to replicate the issue (include links if applicable):

Edit a page, e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Test_4&action=edit
Turn on Realtime Preview
Type some text and wait more than 5 seconds (for the preview to load, and Edit Recovery to store the text)
Type some more text
What for the preview to reload

What happens?:

The second text typed disappears and the edit form is restored to the earlier state by Edit Recovery.

What should have happened instead?:

The new state of the form should've been saved by Edit Recovery.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T345051

Details

	Subject	Repo	Branch	Lines +/-
	Edit Recovery: only load recovery data once	mediawiki/core	master	+5 -1

Customize query in gerrit

Event Timeline

Samwilson created this task.Aug 28 2023, 1:59 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptAug 28 2023, 1:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 952562 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: only load recovery data once

https://gerrit.wikimedia.org/r/952562

gerritbot added a project: Patch-For-Review.Aug 28 2023, 2:08 AM

Samwilson claimed this task.Aug 28 2023, 2:08 AM

Samwilson edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Aug 28 2023, 2:53 AM

Change 952562 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: only load recovery data once

https://gerrit.wikimedia.org/r/952562

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2023, 5:30 PM

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Aug 28 2023, 11:48 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 4:01 AM

@Samwilson The second state does not disappear and the new state of the form is saved by Edit Recovery as seen in the gif below. Moving the task to Done. Thanks for all your work!

Status: ✅ PASS
Environment: Beta
OS: macOS Ventura 13.5
Browser: Chrome 116
Device: MBP
Emulated Device:: N/A
Test Link:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Test_4&action=edit

✅AC1: https://phabricator.wikimedia.org/T345051

2023-09-05_13-56-48.mp4.gif (1×3 px, 3 MB)

MusikAnimal closed this task as Resolved.Sep 6 2023, 6:07 PM

Edit recovery data is loaded on every realtime previewClosed, ResolvedPublicBUG REPORTActions

Description

QA Results - Beta

Details

Event Timeline

Edit recovery data is loaded on every realtime preview
Closed, ResolvedPublicBUG REPORT
Actions