Update Quibble setuptools check to modern alternative
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Aug 28 2023, 4:54 PM

Description

With Gerrit 540882 I introduced tox -e check to validate the package. It runs:

python setup.py --version
python setup.py check

The check is configured via:

setup.cfg

[check]
metadata = true
# Requires docutils
#restructuredtext = true
strict = true

Both commands now raises a deprecation warning about requirements that should be satisfied by a PEP 517 installer.

check: commands[1]> python setup.py check
/home/hashar/projects/integration/quibble/.tox/venv-py3/lib/python3.11/site-packages/setuptools/__init__.py:84: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
!!

        ********************************************************************************
        Requirements should be satisfied by a PEP 517 installer.
        If you are using pip, you can try `pip install --use-pep517`.
        ********************************************************************************

!!
  dist.fetch_build_eggs(dist.setup_requires)
running check

I guess we can live without output the version, but the checks should be kept around. I could not determine what setuptools check verifies exactly nor how to port those verification or whether they are sill needed.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
dockerfiles: update Quibble to 1.6.0	integration/config	master	+63 -1
release: Quibble 1.6.0	integration/quibble	master	+35 -3
Migrate from setup.py to pyproject.toml (PEP 517)	integration/quibble	master	+85 -70

Customize query in gerrit

Related Objects

Mentioned In: T380135: docker-pkg cannot be installed with the given instructions on Ubuntu Noble / python 3.12
T348434: tox v4 recreate test environment sharing the same envdir / env_dir
T345695: Deal with tox 4 upgrading
Mentioned Here: T345695: Deal with tox 4 upgrading
T348434: tox v4 recreate test environment sharing the same envdir / env_dir

Event Timeline

hashar created this task.Aug 28 2023, 4:54 PM

thcipriani triaged this task as Low priority.Aug 30 2023, 4:42 PM

thcipriani edited projects, added Release-Engineering-Team (Seen); removed Release-Engineering-Team.

For python setup.py --version that can be replaced by:

tox.ini

[testenv:check]
deps = setuptools_scm
commands = python -m setuptools_scm

For python setup.py check I think we should move Quibble to pyproject.toml and a build system. https://packaging.python.org/en/latest/tutorials/packaging-projects/ is a good reference.