i18n: checkuser-api-useragent-clienthints-explanation should be project agnostic
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarcoAurelio
	Sep 4 2023, 10:06 AM

Description

Reading https://www.mediawiki.org/wiki/Extension:CheckUser/Client_Hints it looks like this is a feature of the chekuser extension itself not a Wikimedia-specific feature. Therefore, the wording of the message should be project agnostic (i.e. remove mentions of Wikimedia in the messages' text).

If needed, a Wikimedia-specific override can be created in WikimediaMessages with additional links to Wikimedia's privacy and access to nonpublic personal data policies.

URL: https://translatewiki.net/wiki/MediaWiki:Checkuser-api-useragent-clienthints-explanation

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T345549

Details

Subject	Repo	Branch	Lines +/-
Fix message key in of Hooks::onMessageCacheFetchOverrides	mediawiki/extensions/WikimediaMessages	master	+1 -1
clienthints: Create wikimedia specific message for API explanation	mediawiki/extensions/WikimediaMessages	master	+4 -0
clienthints: Remove mention of Wikimedia in API explaination	mediawiki/extensions/CheckUser	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW3f6d5c7bd62e: Merge "SpecialLinkSearch: remove outdated comment about http:// default"
rEWMEd74f676eb6c2: Merge "Correcting typo in en.json re: lbe language name"

Event Timeline

MarcoAurelio created this task.Sep 4 2023, 10:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2023, 10:06 AM

Thanks for filing this.

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 4 2023, 10:08 AM

Change 954611 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] clienthints: Remove mention of Wikimedia in API explaination

https://gerrit.wikimedia.org/r/954611

gerritbot added a project: Patch-For-Review.Sep 4 2023, 10:15 AM

Change 954616 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaMessages@master] clienthints: Create wikimedia specific message for API explaination

https://gerrit.wikimedia.org/r/954616

Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 4 2023, 10:59 AM

Dreamy_Jazz added a project: http-client-hints.

Dreamy_Jazz added a project: WikimediaMessages.Sep 4 2023, 11:07 AM

Dreamy_Jazz moved this task from Backlog to Patches for review on the WikimediaMessages board.

Change 954611 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] clienthints: Remove mention of Wikimedia in API explaination

https://gerrit.wikimedia.org/r/954611

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 4 2023, 1:00 PM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 5 2023, 3:26 PM

Change 954616 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] clienthints: Create wikimedia specific message for API explanation

https://gerrit.wikimedia.org/r/954616

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.26; 2023-09-12); removed MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Sep 5 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2023, 4:10 PM

I would suggest that QA checks if the appropriate message is shown in the response to the API request, depending on whether the WikimediaMessages extension is loaded.

Change 958553 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaMessages@master] Fix message key in of Hooks::onMessageCacheFetchOverrides

https://gerrit.wikimedia.org/r/958553

gerritbot added a project: Patch-For-Review.Sep 18 2023, 6:53 PM

@GMikesell-WMF managed to find that the WikimediaMessages extension doesn't actually load the custom message. I investigated this and found that this was an error on my part. I have fixed this in the patch just above.

Dreamy_Jazz moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 18 2023, 6:54 PM

Change 958553 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Fix message key in of Hooks::onMessageCacheFetchOverrides

https://gerrit.wikimedia.org/r/958553

Dreamy_Jazz moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 18 2023, 7:14 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2023, 7:30 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 18 2023, 8:00 PM

@Dreamy_Jazz Wikimediamessages responses are now appropriate when the Wikimediamessages are enabled vs disabled. I will move this to Done. Thank you for all your work!

Status: ✅ PASS
Environment: Local:1.41.0-alpha (3f6d5c7)08:56, 15 September 2023. CheckUser: 2.5 (b1e7ca2) 06:42, 18 September 2023. Wikimediamessages: (d74f676) 14:12, 18 September 2023
OS: macOS Ventura
Browser: Chrome 116
Device: MBA M2
Emulated Device:: N/A
Test Links:
http://localhost:8080/wiki/Beer