Looks like Shellbox is using Guzzle HTTP client directly (created by HttpRequestFactory), not MwHttpRequest nor MultiHttpClient.
It supports X-Request-Id header, but it's adding it manually in the ShellboxClientFactory, instead of depending on HTTPRequestFactory to prepare the HTTPClient.
Definition of done:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| shellbox: Use Telemetry class instead of WebRequest::getRequestId() | mediawiki/core | master | +40 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T340551 distributed tracing epic | |||
| Open | None | T320549 distributed tracing v0 [minimum viable] | |||
| Open | None | T320556 Micro-specification for how service owners should propagate tracing headers | |||
| Resolved | pmiazga | T346209 Send tracing headers from Shellbox client |
Change 957245 had a related patch set uploaded (by Pmiazga; author: Pmiazga):
[mediawiki/core@master] shellbox: Use Telemetry class instead of deprecated WebRequest::getRequestId()
Change 957245 merged by jenkins-bot:
[mediawiki/core@master] shellbox: Use Telemetry class instead of WebRequest::getRequestId()