Page MenuHomePhabricator

[WtC] Reuse custom layout and spacing variables in Query Builder
Open, Needs TriagePublic

Description

Problem

The layout and component spacing of the different views and elements of the Query Builder app were defined using $dimension-layout and $dimension-spacing WiKit tokens, which consume values in rem and em units respectively.

We need to replace these legacy styles, but the new Wikimedia design system (Codex) doesn't include equivalent tokens that use the same units of measurement, which we prefer to use due to consistent scaling/accessibility and predictability reasons. Instead, it provides only spacing tokens in px.

Solution

In order to unblock the migration project and preserve our preferred approach to pacing, we created a set of reusable spacing variables to replace existing WiKit $dimension-layout and $dimension-spacing tokens (see T350189). Now we need to reuse said variables in the Query Builder to replace WiKit tokens.

Considerations

The layout spacing of the Query Builder tool should not change as a consequence of this replacement.

Acceptance criteria
  • WiKit layout and spacing tokens used to style the Query Builder app are replaced by our new reusable custom variables
  • Current layout and spacing values remain unaltered after the replacement

Event Timeline

Sarai-WMDE renamed this task from [WtC-M2] Create custom layout spacing variables to [WtC-M2] Create custom layout and spacing variables.Sep 15 2023, 1:22 PM
Sarai-WMDE renamed this task from [WtC-M2] Create custom layout and spacing variables to [SW] [WtC-M2] Create custom layout and spacing variables.Oct 23 2023, 4:04 PM
Sarai-WMDE renamed this task from [SW] [WtC-M2] Create custom layout and spacing variables to [SW] [WtC-M2] Reuse custom layout and spacing variables in Mismatch Finder.Nov 8 2023, 11:06 AM
Sarai-WMDE updated the task description. (Show Details)
Sarai-WMDE renamed this task from [SW] [WtC-M2] Reuse custom layout and spacing variables in Mismatch Finder to [WtC] Reuse custom layout and spacing variables in Query Builder.Nov 22 2023, 10:14 AM
Sarai-WMDE edited projects, added Wikidata Query Builder; removed Mismatch Finder.
Sarai-WMDE updated the task description. (Show Details)