Move notification servers config to local files
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• jnuche
	Sep 14 2023, 10:54 AM

Description

Currently, the aphlict configuration used by Phab/Phorge is stored in the DB as a hidden & locked config. The configuration doesn't contain any sensitive data and it would be better to have it committed in a repo somewhere so it can be added to the local Phorge disk config files.

It seems like the config did live in Puppet at some point when aphlict was collocated on the same machine with Phorge, but it's currently disabled. Then it was presumably moved to the DB manually when aphlict was moved to its own separate host.

We can add the configuration to Puppet, so it becomes part of the standard process of bootstrapping a Phorge target or alternatively, the configuration could live in the Scap3 deployment repository, where it would be part of our deployments.

Details

	Subject	Repo	Branch	Lines +/-
	phabricator: add configuration for the remote aphlict server	operations/puppet	production	+29 -6

Customize query in gerrit

Related Objects

Mentioned Here: T239355: Deprecate phabricator's fixed_settings.yaml (in puppet) and just use phabricator's built in configuration tools

Event Timeline

• jnuche created this task.Sep 14 2023, 10:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2023, 10:54 AM

@eoghan would you happen to know why the config value was added manually to the DB instead of keeping it in Puppet?

Note there is/was some work to move to the DB model for more config compared to the files, T239355: Deprecate phabricator's fixed_settings.yaml (in puppet) and just use phabricator's built in configuration tools

@Peachey88 Thanks for pointing to that. I'm not sure it applies anymore though, given we are more recently creating most of the Phab config with Puppet and writing it to files: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/profile/manifests/phabricator/main.pp#280. But it probably explains the decision.

Change 961045 had a related patch set uploaded (by Jaime Nuche; author: Jaime Nuche):

[operations/puppet@production] phabricator: add configuration for the remote aphlict server

https://gerrit.wikimedia.org/r/961045

gerritbot added a project: Patch-For-Review.Sep 26 2023, 9:04 AM

Change 961045 merged by EoghanGaffney: