Maniphest T346830

Unit test form component interaction with API
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Sep 19 2023, 7:12 PM

Tags

Referenced Files

None

Subscribers

Description

Following up from T345257: Wire the reporting form to the API endpoint, this is a task to write Jest tests for the form's POST request to the report incident API.

Acceptance criteria:

There is at least one test relating to the restPayload object from Form.js

Details

	Subject	Repo	Branch	Lines +/-
	Test that a unsuccessful API response keeps the the dialog open	mediawiki/extensions/ReportIncident	master	+28 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T337566 [EPIC]: Incident Reporting System - Minimal Testable Product (MTP)
		Resolved		Dreamy_Jazz	T346830 Unit test form component interaction with API

Event Timeline

kostajh created this task.Sep 19 2023, 7:12 PM

Restricted Application added a project: Trust and Safety Tools Team Backlog. · View Herald TranscriptSep 19 2023, 7:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh added a parent task: T337566: [EPIC]: Incident Reporting System - Minimal Testable Product (MTP).Sep 19 2023, 7:12 PM

Mostly done, but I can add one more test for this.

Change 964060 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ReportIncident@master] Test that a not successful API response doesn't close the dialog

https://gerrit.wikimedia.org/r/964060

gerritbot added a project: Patch-For-Review.Oct 6 2023, 6:06 PM

Dreamy_Jazz edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Trust and Safety Tools Team Backlog.Oct 9 2023, 9:00 AM

Dreamy_Jazz moved this task from 🎬 Ready to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.

kostajh closed this task as Resolved.Oct 9 2023, 1:05 PM

kostajh updated the task description. (Show Details)

Change 964060 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Test that a unsuccessful API response keeps the the dialog open

https://gerrit.wikimedia.org/r/964060

Dreamy_Jazz mentioned this in rEREIb6d28bd32713: Test that a unsuccessful API response keeps the the dialog open.Oct 9 2023, 1:47 PM

Dreamy_Jazz moved this task from 🔍 Review/Feedback to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 9 2023, 1:47 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 9 2023, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2023, 2:10 PM