Limited width doesn't persist for IP masked users
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

e.g. https://de.wikipedia.beta.wmflabs.org/wiki/NaturGeoTabelle_DE?vectorclientpreferences=0

Make an edit on a wiki to become an IP masked user
Disable limited width
Refresh page

What happens?:
The limited width does not persist

What should have happened instead?:

The limited width should persist.

The reason it doesn't persist is that the inline script for client preferences only gets added for anonymous users. Since IP masked users are registered users they do not get the script. User preferences do not work for IP masked users, so clicking the limited width doesn't have any effect.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	OutputPage: Client preferences should work for Temp users	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T345664: How should client preferences work for logged in users?
Mentioned Here: T337103: Decide a standard approach for classifying temporary, IP and registered users
T330815: Disallow preference setting by temporary users
T332414: Make ApiOptions unavailable to temporary users
T345664: How should client preferences work for logged in users?

Event Timeline

Jdlrobson created this task.Sep 19 2023, 7:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2023, 7:20 PM

Related: T345664

Jdlrobson mentioned this in T345664: How should client preferences work for logged in users?.Sep 21 2023, 12:09 AM

Change 959364 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] OutputPage: Client preferences should work for IP masked users

https://gerrit.wikimedia.org/r/959364

gerritbot added a project: Patch-For-Review.Sep 21 2023, 12:13 AM

Our terminology about anonymous users has evolved since the TDMP process so given the framing of T330815 stating that we want "temporary users as consistent as possible with the current experience of unregistered editors" I assume this is just a bug.

If we are reconsidering the decision (alluded to in T332414#9014448) then this would be blocked on T345664.

Jdlrobson added a project: Patch-For-Review.Sep 21 2023, 12:33 AM

ovasileva triaged this task as Medium priority.Sep 21 2023, 5:49 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog.

In T346832#9185507, @gerritbot wrote:

Change 959364 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] OutputPage: Client preferences should work for IP masked users

https://gerrit.wikimedia.org/r/959364

The change to isRegistered to isNamed is fine indeed. I mentioned this two weeks ago at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/957378/1/includes/Output/OutputPage.php.

I also mentioned at the time that this change may be redundant as IP Masking is still in flux. As you can imagine, there are hundreds of isRegistered calls like across core and extensions that will need to be audited and evaluated. Details at T337103 / https://docs.google.com/document/d/1MzjgtPcwoz4bnZQx0h2hhMG-jTX2pqxg6tgq5rI0gnM/edit

Anyway, even if temp users will eventually return isRegistered=false, checking isNamed is umambigious and safe long-term indeed. Thanks for the bug fix!

Change 959364 merged by jenkins-bot:

[mediawiki/core@master] OutputPage: Client preferences should work for Temp users

https://gerrit.wikimedia.org/r/959364

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 25 2023, 3:00 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)); removed Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Sep 25 2023, 5:21 PM

Jdlrobson moved this task from Incoming to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Oct 10 2023, 5:05 PM