Unable to activate Phonos button with keyboard when it has an error
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Sep 21 2023, 1:49 PM

Description

What is the problem?

If a Phonos button has an error, you cannot open the error popup using the keyboard to see what the error is.

The exception seems to be if you have already opened the popup by clicking the button first.

Steps to reproduce problem

https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Errors
Tab until one of the Phonos buttons has focus
Press enter or space

Expected behavior: Error popup should appear
Observed behavior: Nothing happens

Environment

Browser: Firefox 102, Chromium 117, Safari 16.5
Wiki(s): https://en.wikipedia.beta.wmflabs.org Phonos 0.1.0 (3af4159) 08:16, 21 September 2023.

Details

	Subject	Repo	Branch	Lines +/-
	Add space key for triggering the error popup	mediawiki/extensions/Phonos	master	+4 -1
	Trigger button on enter as well as click	mediawiki/extensions/Phonos	master	+11 -4

Customize query in gerrit

Related Objects

Mentioned In: T350369: Errors in mw-client-NEW-errors TypeError: Cannot read properties of undefined (reading 'Keys')
rEPHN3b14b7c16519: Add space key for triggering the error popup
rEPHN1af2997bad71: Trigger button on enter as well as click
Mentioned Here: rEPHN3b14b7c16519: Add space key for triggering the error popup
rEPHN3af4159944b7: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Sep 21 2023, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2023, 1:49 PM

TheresNoTime moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Oct 11 2023, 1:42 PM

Change 967396 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Phonos@master] Trigger button on enter as well as click

https://gerrit.wikimedia.org/r/967396

gerritbot added a project: Patch-For-Review.Oct 20 2023, 8:19 AM

Change 967396 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Trigger button on enter as well as click

https://gerrit.wikimedia.org/r/967396

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 23 2023, 11:00 AM

Restricted Repository Identity mentioned this in rEPHN1af2997bad71: Trigger button on enter as well as click.Oct 23 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2023, 11:10 AM

Samwilson claimed this task.Oct 25 2023, 6:17 AM

Samwilson edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.

Change 968554 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Phonos@master] Add space key for triggering the error popup

https://gerrit.wikimedia.org/r/968554

gerritbot added a project: Patch-For-Review.Oct 25 2023, 6:24 AM

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Oct 25 2023, 6:24 AM

I forgot to add the space key.

Change 968554 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Add space key for triggering the error popup

https://gerrit.wikimedia.org/r/968554

Samwilson mentioned this in rEPHN3b14b7c16519: Add space key for triggering the error popup.Oct 25 2023, 8:51 AM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.3; 2023-10-31); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 25 2023, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2023, 9:10 AM

TheresNoTime moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Oct 25 2023, 10:29 AM

I can activate Phonos buttons with errors with enter and space.

Pressing space or enter again closes the error popup.

It is possible to open multiple error popups for different Phonos buttons if you are using a keyboard, but pressing escape will close them all.

In case of regressions, I tested that clicking still worked and that Phonos buttons without errors can be activated with mouse, enter and space.

Tested various combinations here https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Combinations.

Test environment: https://en.wikipedia.beta.wmflabs.org Phonos 0.1.0 (3b14b7c) 06:23, 25 October 2023.
Test browsers:

Firefox 115
Chromium 118
Safari 14
Edge 111

TheresNoTime closed this task as Resolved.Oct 31 2023, 1:36 PM

TheresNoTime mentioned this in T350369: Errors in mw-client-NEW-errors TypeError: Cannot read properties of undefined (reading 'Keys').Nov 6 2023, 10:55 AM

Unable to activate Phonos button with keyboard when it has an errorClosed, ResolvedPublicBUG REPORTActions