Page MenuHomePhabricator

Form posts "something else" details, even if "something else" behavior is not checked
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Fill out the incident report form
  • Check the box for "Something else"
  • Fill in some text in the free text area for the "Something else" field
  • Uncheck the box for "Something else"

What happens?:

  • The form posts the free text area contents for "something else" even though the checkbox is unchecked

What should have happened instead?:

The "something else" text field contents should not be posted if the "something else" checkbox is unchecked.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 959799 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] form: Only post somethingElseDetails if checkbox is selected

https://gerrit.wikimedia.org/r/959799

Change 959799 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] form: Only post somethingElseDetails if checkbox is selected

https://gerrit.wikimedia.org/r/959799

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/857c992ac1/w

Djackson-ctr subscribed.

I have verified the information listed in the ticket Description (in regards to the "What should have happened instead?") has been implemented and is working successfully at https://patchdemo.wmflabs.org/wikis/857c992ac1/w/index.php?title=User_talk:Patch_Demo&action=edit&redlink=1

image.png (861×1 px, 79 KB)
image.png (844×1 px, 100 KB)
image.png (719×980 px, 173 KB)
image.png (763×1 px, 175 KB)

Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/857c992ac1/w/