Page MenuHomePhabricator
Create Task
Maniphest T347102

Alias column names in Special:Investigate to not include the "cuc_" prefix
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Special:Investigate needs to reference column names that have no "cuc_" prefix as when reading from the three tables the prefix for a set of rows will be different.

Acceptance criteria
  • Alias the current query info fields in TimelineService, TimelinePager and TimelineRowFormatter use aliases for the cu_changes fields that are selected
  • Alias the current query info fields in CompareService and ComparePager use aliases for the cu_changes fields that are selected

Details

SubjectRepoBranchLines +/-
Alias SELECT queries for Investigate 'Timeline' tabmediawiki/extensions/CheckUsermaster+206 -63
Alias SELECT queries for Investigate 'IPs & User agents' tabmediawiki/extensions/CheckUsermaster+72 -71
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Sep 21 2023, 6:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2023, 6:11 PM
Dreamy_Jazz mentioned this in T329201: Enable read new support in Special:Investigate's 'IPs & User agents' tab.Sep 21 2023, 6:12 PM
Dreamy_Jazz mentioned this in T329200: Enable read new support in Special:Investigate's 'Timeline' tab.
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Dreamy_Jazz added parent tasks: T329200: Enable read new support in Special:Investigate's 'Timeline' tab, T329201: Enable read new support in Special:Investigate's 'IPs & User agents' tab.
gerritbot added a comment.Sep 21 2023, 6:25 PM

Change 959836 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] SpecialInvestigate: Alias SELECT fields for cu_changes queries

https://gerrit.wikimedia.org/r/959836

gerritbot added a project: Patch-For-Review.Sep 21 2023, 6:25 PM
Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Sep 21 2023, 8:31 PM
Dreamy_Jazz moved this task from CheckUser to Investigate on the CheckUser board.
Dreamy_Jazz edited projects, added Anti-Harassment; removed Patch-For-Review, Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Oct 2 2023, 2:36 PM

Moving out of the current sprint.

Dreamy_Jazz moved this task from Untriaged to CheckUser on the Anti-Harassment board.Oct 2 2023, 2:37 PM
gerritbot added a comment.Oct 8 2023, 9:43 PM

Change 959836 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] SpecialInvestigate: Alias SELECT fields for cu_changes queries

Reason:

https://gerrit.wikimedia.org/r/959836

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team; removed Anti-Harassment.Apr 11 2024, 2:46 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
gerritbot added a comment.Apr 11 2024, 2:47 PM

Change #959836 restored by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] SpecialInvestigate: Alias SELECT fields for cu_changes queries

https://gerrit.wikimedia.org/r/959836

gerritbot added a project: Patch-For-Review.Apr 11 2024, 2:47 PM
Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Apr 15 2024, 12:08 PM

Blocked on T362152

Dreamy_Jazz added a subtask: T362152: Improve test coverage on Special:Investigate code.Apr 15 2024, 12:14 PM
Dreamy_Jazz set the point value for this task to 3.Apr 19 2024, 11:38 AM
Dreamy_Jazz closed subtask T362152: Improve test coverage on Special:Investigate code as Resolved.Apr 19 2024, 3:45 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)); removed Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)).Apr 23 2024, 10:55 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)); removed Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).Apr 23 2024, 10:58 AM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.Apr 23 2024, 1:14 PM
gerritbot added a comment.Apr 23 2024, 5:48 PM

Change #1023476 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Alias SELECT queries for Investigate 'IPs & User agents' tab

https://gerrit.wikimedia.org/r/1023476

gerritbot added a comment.Apr 24 2024, 4:30 PM

Change #1023890 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add common grouping and sorting methods to CheckUserLookupUtils

https://gerrit.wikimedia.org/r/1023890

Dreamy_Jazz mentioned this in T363376: Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication.Apr 24 2024, 6:54 PM
Dreamy_Jazz removed a subtask: T363376: Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication.Apr 24 2024, 8:04 PM
Dreamy_Jazz added a subtask: T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode.Apr 25 2024, 9:50 AM
Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.Apr 26 2024, 10:02 AM
Dreamy_Jazz mentioned this in T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode.Apr 30 2024, 1:48 PM
Dreamy_Jazz closed subtask T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode as Resolved.
Dreamy_Jazz reopened subtask T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode as Open.Apr 30 2024, 1:51 PM
Dreamy_Jazz moved this task from Ready to Needs Review on the Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)) board.May 1 2024, 7:38 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)).May 13 2024, 9:25 AM
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
Dreamy_Jazz closed subtask T338419: CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode as Resolved.May 13 2024, 3:39 PM
gerritbot added a comment.May 13 2024, 5:54 PM

Change #1023476 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Alias SELECT queries for Investigate 'IPs & User agents' tab

https://gerrit.wikimedia.org/r/1023476

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 13 2024, 6:00 PM
gerritbot added a comment.May 15 2024, 4:53 PM

Change #959836 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Alias SELECT queries for Investigate 'Timeline' tab

https://gerrit.wikimedia.org/r/959836

Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 15 2024, 5:00 PM

Proposing that no QA is performed because this should have performed no changes and this will be QA'd through parent tickets.

Dreamy_Jazz closed this task as Resolved.May 15 2024, 5:00 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 15 2024, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits