Enable read new support in Special:Investigate's 'IPs & User agents' tab
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Now that CheckUser writes to the new tables for event table migration (T330158), reading from these tables when the migration stage is set to read new can commence.

This task is to add support to read new in Special:Investigate's 'IPs & User agents' tab.

Acceptance criteria

Alias the current query info fields in CompareService and ComparePager use aliases for the cu_changes fields that are selected (T347102)
Update the CompareService to select results from the three tables if read new is set

Details

Subject	Repo	Branch	Lines +/-
Add read new support to the 'Compare' tab of Special:Investigate	mediawiki/extensions/CheckUser	master	+416 -96
Pass ServiceOptions to ChangeService	mediawiki/extensions/CheckUser	master	+46 -1
Add test data for new result tables to CompareTableTestDataTrait	mediawiki/extensions/CheckUser	master	+78 -0
Avoid mocking ServiceOptions in CompareService integration test	mediawiki/extensions/CheckUser	master	+6 -21
Add read new support to the ChangeService	mediawiki/extensions/CheckUser	master	+21 -10
Use common DB setup for CompareServiceTest and ComparePagerTest	mediawiki/extensions/CheckUser	master	+148 -229

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T329189 Add read new support to Special:Investigate for event table migration
Resolved	Dreamy_Jazz	T329201 Enable read new support in Special:Investigate's 'IPs & User agents' tab
Resolved	Dreamy_Jazz	T328988 Create a SelectQueryBuilder that allows selecting from all three tables
Resolved	Dreamy_Jazz	T347102 Alias column names in Special:Investigate to not include the "cuc_" prefix
Resolved	Dreamy_Jazz	T362152 Improve test coverage on Special:Investigate code
Declined	Dreamy_Jazz	T363376 Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication
		· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 8 2023, 4:54 PM

Dreamy_Jazz added a subtask: T328988: Create a SelectQueryBuilder that allows selecting from all three tables.

Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Feb 8 2023, 11:56 PM

Dreamy_Jazz moved this task from General / Unsorted to Investigate on the CheckUser board.

Dreamy_Jazz closed subtask T328988: Create a SelectQueryBuilder that allows selecting from all three tables as Resolved.Apr 23 2023, 2:12 PM

Dreamy_Jazz moved this task from Untriaged to CheckUser on the Anti-Harassment board.Jul 22 2023, 5:49 PM

Dreamy_Jazz mentioned this in T329189: Add read new support to Special:Investigate for event table migration.Sep 21 2023, 6:03 PM

Dreamy_Jazz renamed this task from Use the CheckUserUnionSelectQueryBuilder in Special:Investigate compare tab to Enable read new support in Special:Investigate's 'IPs & User agents' tab.Sep 21 2023, 6:07 PM

Dreamy_Jazz claimed this task.

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment.

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz updated the task description. (Show Details)Sep 21 2023, 6:12 PM

Dreamy_Jazz added a subtask: T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix.

Moving out of the current sprint.

Dreamy_Jazz added a subtask: T362152: Improve test coverage on Special:Investigate code.Apr 11 2024, 11:35 AM

Dreamy_Jazz closed subtask T362152: Improve test coverage on Special:Investigate code as Resolved.Apr 19 2024, 3:45 PM

Dreamy_Jazz added a subtask: T363376: Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication.Apr 24 2024, 8:04 PM

Dreamy_Jazz claimed this task.Apr 25 2024, 2:41 PM

Dreamy_Jazz set the point value for this task to 2.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).

Dreamy_Jazz added a project: Trust and Safety Product Team.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Dreamy_Jazz removed a project: Anti-Harassment.

Dreamy_Jazz closed subtask T363376: Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication as Declined.May 1 2024, 7:41 PM

Change #1026550 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use IExpression objects in ChangeService

https://gerrit.wikimedia.org/r/1026550

gerritbot added a project: Patch-For-Review.May 2 2024, 12:42 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Patch-For-Review, Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).May 13 2024, 9:18 AM

Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 13 2024, 9:33 AM

Change #1024417 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add read new support to the ComparePager and CompareService

https://gerrit.wikimedia.org/r/1024417

gerritbot added a project: Patch-For-Review.May 14 2024, 11:30 PM

Dreamy_Jazz changed the point value for this task from 2 to 3.May 15 2024, 12:00 PM

Change #1031876 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use common DB setup for CompareServiceTest and ComparePagerTest

https://gerrit.wikimedia.org/r/1031876

Change #1031883 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add read new support to the ChangeService

https://gerrit.wikimedia.org/r/1031883

Change #1031891 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add test data for new result tables to CompareTableTestDataTrait

https://gerrit.wikimedia.org/r/1031891

Change #1031895 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Avoid mocking ServiceOptions in CompareService integration test

https://gerrit.wikimedia.org/r/1031895

Dreamy_Jazz moved this task from Ready to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 15 2024, 4:42 PM

Dreamy_Jazz closed subtask T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix as Resolved.May 15 2024, 5:00 PM

Change #1031876 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use common DB setup for CompareServiceTest and ComparePagerTest

https://gerrit.wikimedia.org/r/1031876

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 16 2024, 3:00 PM

Change #1031883 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add read new support to the ChangeService

https://gerrit.wikimedia.org/r/1031883

Change #1031891 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add test data for new result tables to CompareTableTestDataTrait

https://gerrit.wikimedia.org/r/1031891

Change #1031895 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Avoid mocking ServiceOptions in CompareService integration test

https://gerrit.wikimedia.org/r/1031895

Dreamy_Jazz moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 20 2024, 11:35 AM

Change #1034550 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Pass ServiceOptions to ChangeService

https://gerrit.wikimedia.org/r/1034550

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 22 2024, 4:31 PM

Change #1034550 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Pass ServiceOptions to ChangeService

https://gerrit.wikimedia.org/r/1034550

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 22 2024, 6:00 PM

Change #1024417 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add read new support to the 'Compare' tab of Special:Investigate

https://gerrit.wikimedia.org/r/1024417

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.Tue, May 28, 10:21 AM

dom_walden edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).Mon, Jun 3, 10:10 AM

dom_walden moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.

I compared the output of the IPs & User agents tab before and after this change. I saw no differences in output.

Test environment: local docker CheckUser 2.5 (14284eb) 07:31, 3 June 2024.

Dreamy_Jazz updated the task description. (Show Details)Mon, Jun 3, 1:58 PM

Dreamy_Jazz closed this task as Resolved.Mon, Jun 3, 3:31 PM

Enable read new support in Special:Investigate's 'IPs & User agents' tabClosed, ResolvedPublic3 Estimated Story PointsActions