Page MenuHomePhabricator
Create Task
Maniphest T362152

Improve test coverage on Special:Investigate code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

As reported by https://doc.wikimedia.org/cover-extensions/CheckUser/src/Investigate/index.html, the code coverage over Investigate related code is low.

Increasing it is important to ensure that the large changes needed to implement T329189: Add read new support to Special:Investigate for event table migration do not cause a Regression.

Acceptance criteria

Details

SubjectRepoBranchLines +/-
Expand SpecialInvestigate integration testsmediawiki/extensions/CheckUsermaster+300 -4
Expand tests for the ComparePagermediawiki/extensions/CheckUsermaster+230 -10
Start on integration tests for SpecialInvestigatemediawiki/extensions/CheckUsermaster+135 -0
Test the TimelineRowFormatter classmediawiki/extensions/CheckUsermaster+293 -0
Add more tests for TokenManager servicemediawiki/extensions/CheckUsermaster+23 -3
Add integration tests for TimelinePagermediawiki/extensions/CheckUsermaster+110 -0
Mark ChangeService as covered by tests for subclassesmediawiki/extensions/CheckUsermaster+13 -1
Test PagerFactory implementations and TimelineRowFormatterFactorymediawiki/extensions/CheckUsermaster+110 -0
Improve test coverage on Investigate Utilities classesmediawiki/extensions/CheckUsermaster+38 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Tue, Apr 9, 12:05 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Tue, Apr 9, 12:27 PM
gerritbot added a comment.Tue, Apr 9, 1:41 PM

Change #1018273 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Improve test coverage for Investigate related code.

https://gerrit.wikimedia.org/r/1018273

gerritbot added a project: Patch-For-Review.Tue, Apr 9, 1:41 PM
Dreamy_Jazz claimed this task.Tue, Apr 9, 1:42 PM
gerritbot added a comment.Wed, Apr 10, 5:44 PM

Change #1018750 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Improve test coverage on Investigate Utilities classes

https://gerrit.wikimedia.org/r/1018750

gerritbot added a comment.Wed, Apr 10, 5:44 PM

Change #1018751 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add more tests for TokenManager service

https://gerrit.wikimedia.org/r/1018751

gerritbot added a comment.Wed, Apr 10, 5:44 PM

Change #1018752 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Mark ChangeService as covered by tests for subclasses

https://gerrit.wikimedia.org/r/1018752

gerritbot added a comment.Wed, Apr 10, 5:44 PM

Change #1018753 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Test PagerFactory implementations and TimelineRowFormatterFactory

https://gerrit.wikimedia.org/r/1018753

gerritbot added a comment.Wed, Apr 10, 5:44 PM

Change #1018754 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add integration tests for TimelinePager

https://gerrit.wikimedia.org/r/1018754

gerritbot added a comment.Wed, Apr 10, 5:46 PM

Change #1018755 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Test the TimelineRowFormatter class

https://gerrit.wikimedia.org/r/1018755

Dreamy_Jazz set the point value for this task to 3.Wed, Apr 10, 6:17 PM
gerritbot added a comment.Wed, Apr 10, 6:48 PM

Change #1018767 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Expand SpecialInvestigate integration tests

https://gerrit.wikimedia.org/r/1018767

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Wed, Apr 10, 10:01 PM
Dreamy_Jazz edited parent tasks, added: T329200: Enable read new support in Special:Investigate's 'Timeline' tab, T329201: Enable read new support in Special:Investigate's 'IPs & User agents' tab; removed: T329189: Add read new support to Special:Investigate for event table migration.Thu, Apr 11, 11:35 AM
Dreamy_Jazz mentioned this in T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix.Mon, Apr 15, 12:09 PM
Dreamy_Jazz added a parent task: T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix.Mon, Apr 15, 12:14 PM
gerritbot added a comment.Mon, Apr 15, 3:25 PM

Change #1018750 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Improve test coverage on Investigate Utilities classes

https://gerrit.wikimedia.org/r/1018750

gerritbot added a comment.Mon, Apr 15, 3:30 PM

Change #1018752 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Mark ChangeService as covered by tests for subclasses

https://gerrit.wikimedia.org/r/1018752

gerritbot added a comment.Mon, Apr 15, 3:30 PM

Change #1018753 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Test PagerFactory implementations and TimelineRowFormatterFactory

https://gerrit.wikimedia.org/r/1018753

gerritbot added a comment.Mon, Apr 15, 3:42 PM

Change #1018754 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add integration tests for TimelinePager

https://gerrit.wikimedia.org/r/1018754

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Mon, Apr 15, 4:00 PM
gerritbot added a comment.Mon, Apr 15, 4:13 PM

Change #1018751 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add more tests for TokenManager service

https://gerrit.wikimedia.org/r/1018751

gerritbot added a comment.Tue, Apr 16, 12:26 PM

Change #1018755 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Test the TimelineRowFormatter class

https://gerrit.wikimedia.org/r/1018755

gerritbot added a comment.Tue, Apr 16, 12:26 PM

Change #1018273 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Start on integration tests for SpecialInvestigate

https://gerrit.wikimedia.org/r/1018273

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.2; 2024-04-23); removed MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Tue, Apr 16, 1:00 PM
gerritbot added a comment.Wed, Apr 17, 6:41 PM

Change #1020899 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Expand tests for the ComparePager

https://gerrit.wikimedia.org/r/1020899

Dreamy_Jazz added a parent task: T362862: Provide two links from Special:Investigate to Special:InvestigateBlock (one for accounts and one for IPs).Thu, Apr 18, 9:56 AM
gerritbot added a comment.Thu, Apr 18, 4:49 PM

Change #1020899 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Expand tests for the ComparePager

https://gerrit.wikimedia.org/r/1020899

gerritbot added a comment.Thu, Apr 18, 5:30 PM

Change #1018767 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Expand SpecialInvestigate integration tests

https://gerrit.wikimedia.org/r/1018767

Tchanders moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Fri, Apr 19, 1:52 PM
Dreamy_Jazz closed this task as Resolved.Fri, Apr 19, 3:45 PM
Dreamy_Jazz updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL