Page MenuHomePhabricator
Create Task
Maniphest T347204

SX suggestions are populated from user published and draft translations
Open, In Progress, MediumPublicBUG REPORT
Actions

Assigned To
ngkountas
Authored By
ngkountas
Sep 22 2023, 6:00 PM
Tags
Referenced Files
F46995545: suggestions_published_transition_loop.webm
Tue, Apr 16, 3:23 PM
F39997220: suggestion_refreshes_new_pages.webm
Oct 25 2023, 2:12 AM
F37751401: Screen Recording 2023-09-22 at 20.24.05(2).webm
Sep 22 2023, 6:00 PM
Subscribers
Aklapper
EChukwukere-WMF
ngkountas

Description

Following the work done for the dashboard published translation list, a new issue has been observed regarding the dashboard page and section suggestions. More specifically, the translation suggestions are populated based on the user published or the draft translations, if any.

As observed in the screencast below, for a user with several translations, (almost) all suggestions are article/sections that have already been translated. This doesn't seem as an efficient way to make suggestions, as it encloses the user in a circle, where they can only see suggestions about articles they have already worked on. Additionally, if the user wants to translate new sections for a draft/published of theirs, they could easily start one from inside the draft/published translation list.

For this reason, this ticket suggests the restoration of the previous way of providing suggestions for article/section translations.

Screencast from greek (el) wiki:

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20240401mediawiki/extensions/ContentTranslationmaster+5 K -5 K
SX: Filter published/draft translations and favorites from suggestionsmediawiki/extensions/ContentTranslationmaster+152 -88
CX3 Build 0.2.0+20230929mediawiki/extensions/ContentTranslationmaster+7 K -6 K
SX dashboard: Do not store suggestions for published translationsmediawiki/extensions/ContentTranslationmaster+37 -9
Customize query in gerrit

Event Timeline

ngkountas created this task.Sep 22 2023, 6:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2023, 6:00 PM
ngkountas claimed this task.Sep 22 2023, 6:00 PM
ngkountas triaged this task as Medium priority.
ngkountas added a project: SectionTranslation.
ngkountas moved this task from Priority: Translation to In Review on the Language-Team (Language-2023-July-September) board.
gerritbot added a comment.Sep 22 2023, 6:35 PM

Change 956950 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX dashboard: Do not store suggestions for published translations

https://gerrit.wikimedia.org/r/956950

gerritbot added a project: Patch-For-Review.Sep 22 2023, 6:35 PM
Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.Sep 25 2023, 11:21 AM
gerritbot added a comment.Sep 26 2023, 2:53 PM

Change 956950 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX dashboard: Do not store suggestions for published translations

https://gerrit.wikimedia.org/r/956950

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 26 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2023, 3:11 PM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-July-September) board.Sep 26 2023, 3:26 PM
gerritbot added a comment.Sep 29 2023, 3:56 PM

Change 962059 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230929

https://gerrit.wikimedia.org/r/962059

gerritbot added a project: Patch-For-Review.Sep 29 2023, 3:56 PM
Pginer-WMF edited projects, added Language-Team (Language-2023-October-December); removed Language-Team (Language-2023-July-September).Oct 2 2023, 8:58 AM
Pginer-WMF moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2023-October-December) board.
gerritbot added a comment.Oct 2 2023, 2:37 PM

Change 962059 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230929

https://gerrit.wikimedia.org/r/962059

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 3:11 PM
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-October-December) board.Oct 5 2023, 3:45 PM
EChukwukere-WMF subscribed.Oct 25 2023, 2:12 AM

Test status: QA PASS

when user clicks the refresh is displays new / different pages

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-October-December) board.Oct 25 2023, 2:13 AM
Pginer-WMF closed this task as Resolved.Oct 27 2023, 8:21 AM
ngkountas reopened this task as In Progress.Mar 4 2024, 8:21 AM
ngkountas edited projects, added Language-Team (Language-2024-January-March); removed Language-Team (Language-2023-October-December).
gerritbot added a comment.Mar 4 2024, 3:50 PM

Change 1008495 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Filter published/draft translations and favorites from suggestions

https://gerrit.wikimedia.org/r/1008495

gerritbot added a project: Patch-For-Review.Mar 4 2024, 3:50 PM
ngkountas renamed this task from SX suggestions are populated from user published translations to SX suggestions are populated from user published and draft translations.Mar 8 2024, 3:01 PM
ngkountas updated the task description. (Show Details)

This task is not done. The above screencast doesn't demonstrate that draft/published translations are filtered from the dashboard suggestion list, it just demonstrates the "Refresh suggestions" feature. Moving this back to "In review" column, following the latest patch.

ngkountas moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-January-March) board.Mar 8 2024, 3:03 PM
gerritbot added a comment.Mar 13 2024, 2:04 PM

Change 1008495 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Filter published/draft translations and favorites from suggestions

https://gerrit.wikimedia.org/r/1008495

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 2:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 13 2024, 7:01 PM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.Mar 13 2024, 8:45 PM
gerritbot added a comment.Mon, Apr 1, 1:36 PM

Change #1015979 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240401

https://gerrit.wikimedia.org/r/1015979

gerritbot added a project: Patch-For-Review.Mon, Apr 1, 1:36 PM
gerritbot added a comment.Mon, Apr 1, 4:11 PM

Change #1015979 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240401

https://gerrit.wikimedia.org/r/1015979

ngkountas removed a project: Patch-For-Review.Tue, Apr 2, 7:37 AM
Pginer-WMF edited projects, added Language-Team (Language-2024-April-June); removed Language-Team (Language-2024-January-March).Tue, Apr 2, 3:22 PM
Pginer-WMF moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2024-April-June) board.
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2024-April-June) board.Mon, Apr 8, 7:13 PM
EChukwukere-WMF added a comment.Tue, Apr 16, 3:23 PM

Per @ngkountas comment I did retest this to ensure the suggestions are not similar to the published or draft translations.

Working as expected

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2024-April-June) board.Tue, Apr 16, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL