Page MenuHomePhabricator

[pre-wmf.29] mw.config.get('wgWikiLambda').zId is not getting set on non-view pages, so no edits are possible
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:

  • The page will display "Loading data" indefinitely
  • The Console will display Uncaught (in promise) missingparam error

Screen Shot 2023-09-27 at 3.02.55 PM.png (756×2 px, 219 KB)

What should have happened instead?:

  • a page should switch into Edit mode successfully for a user with proper editing rights

Event Timeline

Error is:

{
    "error": {
        "code": "missingparam",
        "info": "The \"wikilambdaload_zids\" parameter must be set.",
        "*": "See https://wikifunctions.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes."
    },
    "servedby": "deployment-mediawiki11"
}
Jdforrester-WMF renamed this task from [wikifunctions-betalabs] Uncaught (in promise) missingparam error on ?action=edit to [pre-wmf.29] mw.config.get('wgWikiLambda').zId is not getting set on non-view pages, so no edits are possible.Sep 28 2023, 2:22 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.

Change 961820 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectEditAction: Use getTitle() not getPageTitle() to get the target page

https://gerrit.wikimedia.org/r/961820

Jdforrester-WMF changed the task status from Open to In Progress.Sep 28 2023, 2:32 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF moved this task from To Triage to In Progress on the Abstract Wikipedia team board.

Change 961820 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectEditAction: Use getTitle() not getPageTitle() to get the target page

https://gerrit.wikimedia.org/r/961820

Checked in beta - works as expected.

Testing notes to Verify in Production:
✅ DONE (wmf.29) - check Implementation, e.g. https://www.wikifunctions.org/view/en/Z10271 (in wmf.28 works as expected)

  • check Edit mode
  • Tests should be ok in both Read and Edit mode (currently in Edit mode tests fail with Tester API call was nothing: http)
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to Medium.Sep 28 2023, 8:25 PM
Etonkovidova reopened this task as Open.