Page MenuHomePhabricator

GrowthExperiments fails CI: mwext-php74-phan-docker
Closed, ResolvedPublic

Description

CI for GrowthExperiments fails on master (test patch). Those are the errors:

13:07:56 includes/EventLogging/WelcomeSurveyLogger.php:63 PhanCoalescingNeverNull Using non-null $this->webRequest->getFuzzyBool('_returnto') of type bool as the left hand side of a null coalescing (??) operation. The right hand side may be unnecessary.
13:07:56 includes/HomepageHooks.php:790 PhanImpossibleTypeComparison Impossible attempt to check if $geEnabled of type int is identical to null of type null
13:07:56 maintenance/ExportWelcomeSurveyMailingListData.php:114 SecurityCheck-SQLInjection Calling method \Wikimedia\Rdbms\SelectQueryBuilder::where() in \GrowthExperiments\Maintenance\ExportWelcomeSurveyMailingListData::execute that outputs using tainted argument #1 (`('user_id <= ' . $toId)`). (Caused by: ../../includes/libs/rdbms/querybuilder/SelectQueryBuilder.php +317) (Caused by: maintenance/ExportWelcomeSurveyMailingListData.php +70; maintenance/ExportWelcomeSurveyMailingListData.php +175; ../../includes/libs/rdbms/querybuilder/SelectQueryBuilder.php +718)
13:07:56 maintenance/ExportWelcomeSurveyMailingListData.php:127 SecurityCheck-SQLInjection Calling method \Wikimedia\Rdbms\SelectQueryBuilder::andWhere() in \GrowthExperiments\Maintenance\ExportWelcomeSurveyMailingListData::execute that outputs using tainted argument #1. (Caused by: ../../includes/libs/rdbms/querybuilder/SelectQueryBuilder.php +344) (Caused by: maintenance/ExportWelcomeSurveyMailingListData.php +69; maintenance/ExportWelcomeSurveyMailingListData.php +175; ../../includes/libs/rdbms/querybuilder/SelectQueryBuilder.php +718)

Event Timeline

This makes it impossible to merge patches to GrowthExperiments.

Change 961708 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [DNM] Test CI

https://gerrit.wikimedia.org/r/961708

Change 961762 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Fix phan for GrowthExperiments

https://gerrit.wikimedia.org/r/961762

Urbanecm_WMF changed the task status from Open to In Progress.Sep 28 2023, 11:30 AM

Change 961762 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix phan for GrowthExperiments

https://gerrit.wikimedia.org/r/961762

Change 961708 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@master] [DNM] Test CI

Reason:

no longer needed

https://gerrit.wikimedia.org/r/961708

Change 963349 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.28] Fix phan for GrowthExperiments

https://gerrit.wikimedia.org/r/963349

Change 963349 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.28] Fix phan for GrowthExperiments

https://gerrit.wikimedia.org/r/963349

Mentioned in SAL (#wikimedia-operations) [2023-10-04T20:46:55Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:963347|SpecialManageMentors: Skip OOUI initialization when transcluding (T346760)]], [[gerrit:963348|SpecialManageMentors: Skip OOUI initialization when transcluding (T346760)]], [[gerrit:963349|Fix phan for GrowthExperiments (T347571)]]

Mentioned in SAL (#wikimedia-operations) [2023-10-04T20:48:20Z] <urbanecm@deploy2002> urbanecm: Backport for [[gerrit:963347|SpecialManageMentors: Skip OOUI initialization when transcluding (T346760)]], [[gerrit:963348|SpecialManageMentors: Skip OOUI initialization when transcluding (T346760)]], [[gerrit:963349|Fix phan for GrowthExperiments (T347571)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-04T20:54:45Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:963347|SpecialManageMentors: Skip OOUI initialization when transcluding (T346760)]], [[gerrit:963348|SpecialManageMentors: Skip OOUI initialization when transcluding (T346760)]], [[gerrit:963349|Fix phan for GrowthExperiments (T347571)]] (duration: 07m 49s)