Page MenuHomePhabricator
Create Task
Maniphest T347668

WlSelect: Use CdxSelect component directly and remove WlSelect from Wikilambda codebase
Closed, ResolvedPublic
Actions

Description

Description

Due to significant design differences that required programmatic behavior, we created WlSelect component as a wrapper of CdxSelect.
However, these design requirements are not there anymore, which means that the WlSelect component is now an unnecessary layer.

Remove the Select component and replace the instances of wl-select with direct cdx-select instances

Completion checklist

Details

SubjectRepoBranchLines +/-
Remove WlSelect from WikiLambda and test expectation for CdxSelectmediawiki/extensions/WikiLambdamaster+4 -74
Stop using WlSelect, use Codex's Select directlymediawiki/extensions/WikiLambdamaster+53 -52
Customize query in gerrit

Event Timeline

gengh created this task.Sep 29 2023, 8:21 AM
Jdforrester-WMF triaged this task as Low priority.Oct 5 2023, 4:34 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
gerritbot added a comment.Dec 5 2023, 8:53 PM

Change 980487 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Merge branch 'master' into grace/T347668/replace-wl-components-with-codex Change-Id: I9aa871afc6bd90d14c365be4977a7cad51eda2aa

https://gerrit.wikimedia.org/r/980487

gerritbot added a project: Patch-For-Review.Dec 5 2023, 8:53 PM
gerritbot added a comment.Dec 6 2023, 4:38 AM

Change 980531 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Merge branch 'master' into grace/T347668/replace-wl-components-with-codex Change-Id: Icab32acf17b84d644b09b2c7ab656fa0f269d52b

https://gerrit.wikimedia.org/r/980531

gerritbot added a comment.Dec 7 2023, 6:28 PM

Change 980531 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Merge branch 'master' into grace/T347668/replace-wl-components-with-codex Change-Id: Icab32acf17b84d644b09b2c7ab656fa0f269d52b

Reason:

Will update branch with different patch

https://gerrit.wikimedia.org/r/980531

gerritbot added a comment.Dec 7 2023, 8:18 PM

Change 980530 had a related patch set uploaded (by Jforrester; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Stop using WlSelect, use Codex's Select directly

https://gerrit.wikimedia.org/r/980530

Jdforrester-WMF changed the task status from Open to In Progress.Dec 7 2023, 8:29 PM
Jdforrester-WMF assigned this task to ecarg.
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Dec 7 2023, 9:09 PM

Change 980530 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Stop using WlSelect, use Codex's Select directly

https://gerrit.wikimedia.org/r/980530

gerritbot added a comment.Dec 7 2023, 10:00 PM

Change 981398 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Remove WlSelect from WikiLambda and test expectation for CdxSelect

https://gerrit.wikimedia.org/r/981398

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 7 2023, 10:00 PM
gerritbot added a comment.Dec 8 2023, 9:45 PM

Change 981398 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove WlSelect from WikiLambda and test expectation for CdxSelect

https://gerrit.wikimedia.org/r/981398

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Dec 8 2023, 9:46 PM
Jdforrester-WMF subscribed.

This is now live on Beta Cluster and will ship to production in the train next week.

Jdforrester-WMF closed this task as Resolved.Dec 12 2023, 4:07 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jan 22 2024, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits