Support multiple roots
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SBisson
	Oct 5 2023, 2:41 PM

Description

Original report: https://github.com/wikimedia/wikipedia-preview/issues/167

When calling the Wikipedia Preview init function, one can specify the root to use as the container for all items with previews. It has been requested that the root can actually be multiple roots. I would go further and say that we should allow specifying a selector (e.g. .content) for consistency and flexibility.

QA Results - WordPress Dev

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T348261 here

Related Objects

Mentioned In: T350698: Modernize build dependencies in WP repo

Event Timeline

SBisson created this task.Oct 5 2023, 2:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2023, 2:41 PM

SBisson triaged this task as Medium priority.Oct 5 2023, 2:41 PM

SBisson claimed this task.Nov 6 2023, 7:58 PM

SBisson moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

SBisson mentioned this in T350698: Modernize build dependencies in WP repo.Nov 7 2023, 3:48 PM

PWaigi-WMF changed the task status from Open to In Progress.Nov 17 2023, 5:38 PM

https://github.com/wikimedia/wikipedia-preview/pull/176

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Dec 6 2023, 9:20 PM

@SBisson When running through some regression testing, I did not come across any new issues. I will move this to design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: WordPress Dev 6.4.2; Wikipedia Preview: commit f8134c6ac58618bd0c9eef77697a59b53cd8ca7e - Mon Dec 11 14:50:53 2023 -0500
OS: macOS Sonoma 14.2
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. N/A
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://dev-test.local/wp-admin/post.php?post=27&action=edit
http://dev-test.local/27-2/